made changes to bfs and vistors that didn't return bool

src/bfs.jl

@@ -71,14 +71,14 @@ function traverse_graph(
     visitor::SimpleGraphVisitor;
     colormap = zeros(Int, nv(graph)))
 
-    que = Queue(Int)
+    que = @compat Vector{Int}()
 
     for s in sources
         colormap[s] = 1
         if !discover_vertex!(visitor, s)
             return
         end
-        DataStructures.enqueue!(que, s)
+        push!(que, s)
     end
 
     breadth_first_visit_impl!(graph, que, colormap, visitor)

src/graphvisit.jl

@@ -52,7 +52,7 @@ end
 
 function discover_vertex!(visitor::VertexListVisitor, v::Int)
     push!(visitor.vertices, v)
-    true
+    return true
 end
 
 function visited_vertices(
@@ -74,24 +74,34 @@ end
 
 function discover_vertex!(vis::LogGraphVisitor, v::Int)
     println(vis.io, "discover vertex: $v")
-    true
+    return true
 end
 
-open_vertex!(vis::LogGraphVisitor, v::Int) = println(vis.io, "open vertex: $v")
-close_vertex!(vis::LogGraphVisitor, v::Int) = println(vis.io, "close vertex: $v")
+function open_vertex!(vis::LogGraphVisitor, v::Int)
+    println(vis.io, "open vertex: $v")
+    return true
+end
+
+function close_vertex!(vis::LogGraphVisitor, v::Int)
+    println(vis.io, "close vertex: $v")
+    return true
+end
 
 function examine_neighbor!(vis::LogGraphVisitor, u::Int, v::Int, vcolor::Int, ecolor::Int)
     println(vis.io, "examine neighbor: $u -> $v (vertexcolor = $vcolor, edgecolor= $ecolor)")
+    return true
 end
 
 function examine_edge!(vis::LogGraphVisitor, e::Edge, color::Int)
     println(vis.io, "examine edge: $e")
 end
 
-function traverse_graph_withlog(g::SimpleGraph, alg::SimpleGraphVisitAlgorithm, sources::Vector{Int}, io::IO)
+function traverse_graph_withlog(
+    g::SimpleGraph,
+    alg::SimpleGraphVisitAlgorithm,
+    sources,
+    io::IO = STDOUT
+)
     visitor = LogGraphVisitor(io)
     traverse_graph(g, alg, sources, visitor)
 end
-
-traverse_graph_withlog(g::SimpleGraph, alg::SimpleGraphVisitAlgorithm,
-    sources::Vector{Int}) = traverse_graph_withlog(g, alg, sources, STDOUT)

test/graphvisit.jl

@@ -0,0 +1,20 @@
+# stub tests for coverage; disregards output.
+
+f = IOBuffer()
+
+g = HouseGraph()
+@test traverse_graph_withlog(g, BreadthFirst(), [1;], f) == nothing
+
+@test visited_vertices(g, BreadthFirst(), [1;]) == [1, 2, 3, 4, 5]
+
+
+function trivialgraphvisit(
+    g::SimpleGraph,
+    alg::LightGraphs.SimpleGraphVisitAlgorithm,
+    sources
+)
+    visitor = TrivialGraphVisitor()
+    traverse_graph(g, alg, sources, visitor)
+end
+
+@test trivialgraphvisit(g, BreadthFirst(), 1) == nothing

test/runtests.jl

@@ -52,6 +52,7 @@ tests = [
     "dfs",
     "connectivity",
     "maxadjvisit",
+    "graphvisit",
     "centrality/betweenness",
     "centrality/closeness",
     "centrality/degree",