Revert "Merge branch 'master' into hotfix-1"

This reverts commit dbf785610ef248a26ed5b3a95d7c5d05e447fb89, reversing
changes made to 5f69d5a.

more optimizations

trivial

doc/pathing.md

@@ -3,15 +3,15 @@ various utility functions. Where appropriate, edge distances may be passed in as
 matrix of real number values. The matrix should be indexed by `[src, dst]` (see [Getting Started](gettingstarted.html) for more information).
 
 ### Graph Traversal
-*Graph traversal* refers to a process that traverses vertices of a graph following certain order (starting from user-input sources). This package implements three traversal schemes:
-* `BreadthFirst`,
-* `DepthFirst`, and
-* `MaximumAdjacency`.
+`Graph traversal` refers to a process that traverses vertices of a graph following certain order (starting from user-input sources). This package implements three traversal schemes:
+` `BreadthFirst`,
+` `DepthFirst`, and
+` `MaximumAdjacency`.
 
-`bfs_tree(g, s)`  
-`dfs_tree(g, s)`  
-Provides a breadth-first or depth-first traversal of the graph `g` starting with source vertex `s`, 
-and returns a directed acyclic graph of vertices in the order they were discovered.
+`bfs_tree(g)`  
+`dfs_tree(g)`  
+Provides a breadth-first or depth-first traversal of the graph `g`, and returns
+a directed acyclic graph of vertices in the order they were discovered.
 
 
 ### Connectivity / Bipartiteness
@@ -25,7 +25,7 @@ of weak connectivity.
 `is_weakly_connected(g)`  
 DiGraphs only: returns true if `g` is strongly (weakly) connected.
 
-`connected_components(g)`  
+`connected components(g)`  
 Will return the [connected components](https://en.wikipedia.org/wiki/Connectivity_(graph_theory))
 of an undirected graph `g` as a vector of components, each represented by a vector
 of vectors of vertices belonging to the component.
@@ -85,8 +85,8 @@ displayed.
 
 ### Shortest-Path Algorithms
 #### General properties of shortest path algorithms
-*  The distance from a vertex to itself is always `0`.
-* The distance between two vertices with no connecting edge is always `Inf`.
+`   The distance from a vertex to itself is always `0`.
+`   The distance between two vertices with no connecting edge is always `Inf`.
 
 
 `a_star(g, s, t[, heuristic, distmx])`  

src/graphvisit.jl

@@ -96,10 +96,12 @@ function examine_edge!(vis::LogGraphVisitor, e::Edge, color::Int)
     println(vis.io, "examine edge: $e")
 end
 
-function traverse_graph_withlog(g::SimpleGraph, alg::SimpleGraphVisitAlgorithm, sources::Vector{Int}, io::IO)
+function traverse_graph_withlog(
+    g::SimpleGraph,
+    alg::SimpleGraphVisitAlgorithm,
+    sources,
+    io::IO = STDOUT
+)
     visitor = LogGraphVisitor(io)
     traverse_graph(g, alg, sources, visitor)
 end
-
-traverse_graph_withlog(g::SimpleGraph, alg::SimpleGraphVisitAlgorithm,
-    sources::Vector{Int}) = traverse_graph_withlog(g, alg, sources, STDOUT)

test/graphvisit.jl

@@ -4,3 +4,17 @@ f = IOBuffer()
 
 g = HouseGraph()
 @test traverse_graph_withlog(g, BreadthFirst(), [1;], f) == nothing
+
+@test visited_vertices(g, BreadthFirst(), [1;]) == [1, 2, 3, 4, 5]
+
+
+function trivialgraphvisit(
+    g::SimpleGraph,
+    alg::LightGraphs.SimpleGraphVisitAlgorithm,
+    sources
+)
+    visitor = TrivialGraphVisitor()
+    traverse_graph(g, alg, sources, visitor)
+end
+
+@test trivialgraphvisit(g, BreadthFirst(), 1) == nothing