Use importlib.metadata on python3.8+ and importlib_metadata for 3.6,3.7 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miigotu
changed the title
miigotu
referenced
this pull request
Apr 9, 2021
This allows us to drop the requirement for setuptools.
…thing up to and including python3.7 Signed-off-by: miigotu <[email protected]>
miigotu
force-pushed
the
no-pkg-resources
branch
from
3d502df
to
413dd27
Compare
sbraz
added a commit
that referenced
this pull request
Apr 9, 2021
Signed-off-by: miigotu <[email protected]>
|
Yeah its no problem, developers just jump in, and this was a smallish change =P Thanks for the project and taking care of this. |
sbraz
added a commit
that referenced
this pull request
Apr 10, 2021
This allows us to drop the requirement for setuptools. Also make __version__ an empty string when the package isn't installed, for improved consistency. Co-Authored-By: miigotu <[email protected]>
sbraz
added a commit
that referenced
this pull request
Apr 10, 2021
This allows us to drop the requirement for setuptools. Also make __version__ an empty string when the package isn't installed, for improved consistency. Co-Authored-By: miigotu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependancy of setuptools for those of us using pyproject.toml and tools such as poetry and flit.
Signed-off-by: miigotu [email protected]