Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Upgrade to jodconverter-local 4.2.3 imply to also add a dependency to jodconverter-core #183

Closed
surli opened this issue Jan 16, 2020 · 8 comments
Assignees
Labels

Comments

@surli
Copy link

surli commented Jan 16, 2020

I just upgraded jodconverter-local on XWiki to 4.2.3 and I got some builds issues because of class not found: after investigation it's because jodconverter-core is no longer retrieved. When adding explicitely the dependency it's working well.

I guess it's related with a1a5809#diff-442861bd065d1a83bdf0bf7cbf606f95R6

surli added a commit to xwiki/xwiki-platform that referenced this issue Jan 16, 2020
  * Explicit the dependency to jodconverter-core (see
    jodconverter/jodconverter#183)
surli added a commit to xwiki/xwiki-platform that referenced this issue Jan 16, 2020
  * Explicit the dependency to jodconverter-core (see
    jodconverter/jodconverter#183)
@sbraconnier
Copy link
Member

It was not supposed to be. Maybe I misunderstood the gradle api dependency. jodconverter-core is supposed to be exposed from jodconverter-local.

I'll fix that today.

@sbraconnier
Copy link
Member

Could you please try the 4.2.4-SNAPSHOT please ??

I don't want to publish another faulty release!! Thank for reporting this by the way 👍

@surli
Copy link
Author

surli commented Jan 16, 2020

Could you please try the 4.2.4-SNAPSHOT please ??

I will try.

FTR our build is currently failing with:

Caused by: org.eclipse.aether.resolution.ArtifactResolutionException: Failure to find org.jodconverter:jodconverter-local:pom:4.2.3 in http://nexus.xwiki.org/nexus/content/groups/public was cached in the local repository, resolution will not be reattempted until the update interval of xwiki-releases has elapsed or updates are forced

our nexus is connected to central so we should have it, and locally I got the warning:

[WARNING] The POM for org.jodconverter:jodconverter-local:jar:4.2.3 is missing, no dependency information available

Not sure what's wrong though, since I can see the pom in https://search.maven.org/remotecontent?filepath=org/jodconverter/jodconverter-local/4.2.3/jodconverter-local-4.2.3.pom

@sbraconnier
Copy link
Member

Hmm... I use the deprecated 'maven' plugin to publish my artifacts. I got a "warning" about missing "repository id" when I released the version. I never saw that before. Not sure why and what the consequences are...

Maybe I'll have to rework my publishing todos list to fix this!

@surli
Copy link
Author

surli commented Jan 16, 2020

Could you please try the 4.2.4-SNAPSHOT please ??

I will try.

So I just rebuilt locally jodconverter with ./gradlew install, remove the dependency to jodconverter-core on XWiki and bump the jodconverter version to 4.2.4-SNAPSHOT and it appears to build properly on my machine.
So at least the first regression seems fixed :)

@sbraconnier
Copy link
Member

Great! Thanks!

I'll publish the version today. Sorry for that!

@surli
Copy link
Author

surli commented Jan 16, 2020

No problem :)

@sbraconnier
Copy link
Member

Fixed by 09b2751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants