-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fredr() and parameter vintage_dates #88
Comments
Nice catch! The API parameter itself accepts a comma separated string of dates but it seems we didn't accommodate for that in the |
Thanks! And, thanks for the quick response! |
Should be fixed with #89 fredr::fredr(series_id = "GDPC1", vintage_dates = as.Date(c("1991-12-04", "1991-12-20")))
#> # A tibble: 132 x 3
#> date series_id value
#> <date> <chr> <dbl>
#> 1 1959-01-01 GDPC1 1910.
#> 2 1959-04-01 GDPC1 1941.
#> 3 1959-07-01 GDPC1 1932.
#> 4 1959-10-01 GDPC1 1943.
#> 5 1960-01-01 GDPC1 1978.
#> 6 1960-04-01 GDPC1 1974.
#> 7 1960-07-01 GDPC1 1976.
#> 8 1960-10-01 GDPC1 1965.
#> 9 1961-01-01 GDPC1 1980.
#> 10 1961-04-01 GDPC1 2009.
#> # … with 122 more rows Created on 2021-01-04 by the reprex package (v0.3.0) |
This change has now been merged the master branch with #89. Will do another CRAN release soon but in the meantime, you can install with |
Thank you! |
From https://cran.r-project.org/web/packages/fredr/fredr.pdf under
fred_series_observations
:However, it appears that
fredr
cannot accept more than one date for parametervintage_dates
:Ideally, when passing multiple dates to
vintage_dates
, a fourth column in the return tibble called, for example,vintage_date
would denote which vintage that data point is from.The text was updated successfully, but these errors were encountered: