Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a common MDN network interface (consistent with new DensityEstimators) #989

Open
manuelgloeckler opened this issue Mar 13, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@manuelgloeckler
Copy link
Contributor

manuelgloeckler commented Mar 13, 2024

Description

The MDN i.e. Gaussian Mixture Density network, is a density estimator which gets a lot of "special" treatment.

  • SNPE_A requires it, and implements a special "corrected" SNPE_A_MDN wrapper.
  • SNPE_C has a special loss for it
  • conditional_density.py implements a special ConditionedMDN to use the "marginalization" properties.

Hence it may be good to collapse all current MDN wrappers/functionalities into a single class MDNDensityEstimator, which does follow the new DensityEstimator.

Advantages:

  • Reducing code duplication.
  • Better typing.
@manuelgloeckler manuelgloeckler added enhancement New feature or request hackathon labels Mar 13, 2024
@manuelgloeckler manuelgloeckler added this to the Hackathon 2024 milestone Mar 13, 2024
@jnsbck jnsbck self-assigned this Mar 18, 2024
@bkmi
Copy link
Contributor

bkmi commented Mar 19, 2024

I find the SNPE_A_MDN class quite confusing. Is there a loss implemented for it yet? Why does it only inherit from DensityEstimator but not implement all methods?

@jnsbck jnsbck linked a pull request Mar 19, 2024 that will close this issue
8 tasks
@jnsbck jnsbck mentioned this issue Mar 19, 2024
8 tasks
@janfb janfb removed the hackathon label Jul 22, 2024
@janfb
Copy link
Contributor

janfb commented Jul 22, 2024

This is being worked on in #1042 but it will not make it into the release in August.

@janfb janfb removed this from the Hackathon 2024 milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants