Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement local simulation-based calibration tests as in Zhao et al. #621

Closed
5 tasks
janfb opened this issue Jan 27, 2022 · 4 comments
Closed
5 tasks

Implement local simulation-based calibration tests as in Zhao et al. #621

janfb opened this issue Jan 27, 2022 · 4 comments
Labels
enhancement New feature or request hackathon
Milestone
Hackathon and rel...

Comments

@janfb
Copy link
Contributor

janfb commented Jan 27, 2022 •
edited by michaeldeistler
Loading

As an additional calibration test, we would like to implement local tests from Zhao et al..

For this, we already have an old draft that never got merged: #379

Subtasks:

  • pick up the PR sbi.diagnostics? #379
  • clean it up
  • make sure it is consistent with the most recent API
  • write proper tests for it
  • write a tutorial for it
@janfb janfb self-assigned this Jan 27, 2022
@psteinb
Copy link
Contributor

psteinb commented Jan 28, 2022

This reads wonderful and likely could be an extension for #590 and #592 ?

@janfb
Copy link
Contributor Author

janfb commented Jan 28, 2022 •
edited
Loading

yes, it could used in an extended version the SBC tutorial.
Inge (@lehcni) is working on the implementation of the local coverage tests.

@michaeldeistler michaeldeistler added the enhancement New feature or request label Feb 14, 2022
@janfb janfb added this to the Hackathon 2024 milestone Feb 16, 2024
@janfb
Copy link
Contributor Author

janfb commented Feb 16, 2024 •
edited
Loading

#628 implements this. It needs review and refactoring.

@janfb janfb removed their assignment Feb 16, 2024
@janfb janfb mentioned this issue Feb 28, 2024
Closed
@janfb
Copy link
Contributor Author

janfb commented Jun 18, 2024 •
edited
Loading

local C2ST implements a local coverage test, which we recommend using for now. see #1109

@janfb janfb closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request hackathon
Projects
None yet
Milestone
Hackathon and release 0.23
Development

No branches or pull requests
3 participants
@psteinb @janfb @michaeldeistler