Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User Warning when accept_reject sampler gets stuck #1292

Open
manuelgloeckler opened this issue Oct 7, 2024 · 0 comments
Open

Add User Warning when accept_reject sampler gets stuck #1292

manuelgloeckler opened this issue Oct 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@manuelgloeckler
Copy link
Contributor

Is your feature request related to a problem? Please describe.
If a prior on a bounded support is provided, then NPE will automatically perform accept_reject sampling. With a fallback to MCMC (should this maybe just directly sampling from the flow?).

In any case, if the acceptance rate is very low, the sampling progress will get "stuck" without any indication of why. This can lead to confusion i.e., see #1287

Describe the solution you'd like
For the rejection sampler, we raise a User Warning (see here) in this case, which we probably also should do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant