Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseCommand is empty after convert_app() #59

Closed
tdelhomme opened this issue Sep 15, 2017 · 4 comments
Closed

baseCommand is empty after convert_app() #59

tdelhomme opened this issue Sep 15, 2017 · 4 comments
Assignees

Comments

@tdelhomme
Copy link

When I try to convert a public app to a tool, the base command is lost.

> t=convert_app(a$public_app(name = "bgzip"))
Warning message:
In .asTool(obj) :
  Extra fields dropped before conversion: sbg:appVersion sbg:projectName cwlVersion

> t$baseCommand
NULL
@tdelhomme
Copy link
Author

tdelhomme commented Sep 18, 2017

@tengfei
I have the same problem when trying to convert an app from JSON file following the tutorial here...

> t1 = system.file("extdata/app", "tool_star.json", package = "sevenbridges")
> # # convert json file into a Tool object
> t1 = convert_app(t1)
> t1$baseCommand
NULL

weird!

@tdelhomme
Copy link
Author

It seems that it happens only when use an array for baseCommand in JSON file, if string is used, baseCommand is well imported in R.

@tengfei
Copy link
Contributor

tengfei commented Sep 28, 2017

Thanks @tdelhomme, it's good catch, I just fix the bug and push it on github with recent two commits. (I also fix warning you got). Please let me know if it still doesn't work

@tengfei tengfei closed this as completed Sep 28, 2017
@nanxstats
Copy link
Contributor

-great! Thanks @tengfei for the fix. I've just pushed the latest changes to Bioconductor. The new version (release: 1.6.4, devel: 1.7.4) will propagate through Bioc's build system and appear on their website in about 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants