Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid variable names #2

Open
mpbzh opened this issue Nov 23, 2024 · 0 comments
Open

Invalid variable names #2

mpbzh opened this issue Nov 23, 2024 · 0 comments

Comments

@mpbzh
Copy link

mpbzh commented Nov 23, 2024

I totally love the fact that SBB is open sourcing the pictograms and icons with reasonable terms of use! Kudos!

Unfortunately the project in its current state cannot be used, as it defines two invalid variable names: 1stClassFramed and 2ndClassFramed. In JavaScript variable names must begin with a letter, underscore or dollar sign, numbers are only allowed starting from the second character.

This causes the whole project (in my case a Vue application) to break.

sbb2
sbb1

I'd love to see these renamed to something compatible like _1stClassFramed or firstClassFramed.

Steps to reproduce:

  1. Set up a vue app (npm create vue@latest)
  2. Install the pictogram library (npm i @sbb-esta/pictograms)
  3. Import any icon into the project (import { Tracks1DeLarge } from '@sbb-esta/pictograms';)

Expected behavior: I should be able to use the icon in my template

Actual behavior: See screenshots above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant