You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I totally love the fact that SBB is open sourcing the pictograms and icons with reasonable terms of use! Kudos!
Unfortunately the project in its current state cannot be used, as it defines two invalid variable names: 1stClassFramed and 2ndClassFramed. In JavaScript variable names must begin with a letter, underscore or dollar sign, numbers are only allowed starting from the second character.
This causes the whole project (in my case a Vue application) to break.
I'd love to see these renamed to something compatible like _1stClassFramed or firstClassFramed.
Steps to reproduce:
Set up a vue app (npm create vue@latest)
Install the pictogram library (npm i @sbb-esta/pictograms)
Import any icon into the project (import { Tracks1DeLarge } from '@sbb-esta/pictograms';)
Expected behavior: I should be able to use the icon in my template
Actual behavior: See screenshots above
The text was updated successfully, but these errors were encountered:
I totally love the fact that SBB is open sourcing the pictograms and icons with reasonable terms of use! Kudos!
Unfortunately the project in its current state cannot be used, as it defines two invalid variable names:
1stClassFramed
and2ndClassFramed
. In JavaScript variable names must begin with a letter, underscore or dollar sign, numbers are only allowed starting from the second character.This causes the whole project (in my case a Vue application) to break.
I'd love to see these renamed to something compatible like
_1stClassFramed
orfirstClassFramed
.Steps to reproduce:
npm create vue@latest
)npm i @sbb-esta/pictograms
)import { Tracks1DeLarge } from '@sbb-esta/pictograms';
)Expected behavior: I should be able to use the icon in my template
Actual behavior: See screenshots above
The text was updated successfully, but these errors were encountered: