Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix and add values for white color #438

Merged
merged 2 commits into from
Sep 16, 2022
Merged

feat: fix and add values for white color #438

merged 2 commits into from
Sep 16, 2022

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Sep 16, 2022 •
edited
Loading

Changes

  • variable --sbb-color-white-alpha-20 has a wrong value for alpha
  • add new variable --sbb-color-white-alpha-30
  • add new variable --sbb-color-black-alpha-30

kyubisation
kyubisation approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

dauriamarco
dauriamarco approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@dauriamarco dauriamarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@DavideMininni-Fincons DavideMininni-Fincons merged commit 0cbf4d8 into master Sep 16, 2022
@DavideMininni-Fincons DavideMininni-Fincons deleted the feat/new-values-white-color branch September 16, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dauriamarco dauriamarco dauriamarco approved these changes

@kyubisation kyubisation kyubisation approved these changes

@jeripeierSBB jeripeierSBB Awaiting requested review from jeripeierSBB

@federicoisepponfincons federicoisepponfincons Awaiting requested review from federicoisepponfincons

@simone-sabato simone-sabato Awaiting requested review from simone-sabato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavideMininni-Fincons @kyubisation @dauriamarco