Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Translucent background for sbb-dialog #2806

Closed
3 tasks done
sandrooco opened this issue Jun 21, 2024 · 0 comments · Fixed by #3325
Closed
3 tasks done

[Feature request]: Translucent background for sbb-dialog #2806

sandrooco opened this issue Jun 21, 2024 · 0 comments · Fixed by #3325
Assignees

Comments

@sandrooco
Copy link
Contributor

Preflight Checklist

Request type

Request for enhancement of a component

It affects the following packages

Components

Functionality

The current implementation of the sbb-dialog component only has the white background.

The design also includes a halfways translucent variant (via the default-background boolean if I understand it correctly).
We would like to have this implemented in the lyne-elements component as well for the following use case:
Screenshot 2024-06-21 at 16 16 10

Thanks in advance for your feedback!

Link to design proposal file

https://www.figma.com/design/9r6xSfNmEfCFxl1yFYedrj/Lyne-Components?node-id=30235-579941&t=5CzZAuYRXpLcSWyt-4

@kyubisation kyubisation moved this from Funnel to To do in ESTA Web Lyne Design System Jun 21, 2024
@jeripeierSBB jeripeierSBB self-assigned this Dec 19, 2024
@jeripeierSBB jeripeierSBB moved this from UX to In progress in ESTA Web Lyne Design System Dec 19, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in ESTA Web Lyne Design System Jan 14, 2025
jeripeierSBB pushed a commit that referenced this issue Jan 16, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.1.0](v2.0.3...v2.1.0)
(2025-01-16)


### Features

* improve stacking context for overlay components
([#3349](#3349))
([7ea0640](7ea0640))
* **sbb-container, sbb-sticky-bar:** add 'midnight' and 'charcoal' color
variants
([#3337](#3337))
([6eee274](6eee274))
* **sbb-dialog:** introduce `backdrop` property to control backdrop
density
([#3325](#3325))
([813b141](813b141)),
closes
[#2806](#2806)
* **sbb-menu:** improvements on arrow navigation
([#3341](#3341))
([d90364f](d90364f))


### Bug Fixes

* fix active color of buttons
([#3327](#3327))
([4a13b78](4a13b78))
* handle datepicker association reliably
([#3339](#3339))
([be060fb](be060fb)),
closes
[#3331](#3331)
* **sbb-select:** handle properties change
([#3334](#3334))
([d6b914a](d6b914a))
* **sbb-select:** respect text node mutations for displayed value
([#3329](#3329))
([707366a](707366a)),
closes
[#3298](#3298)


### Documentation

* fix radio button group change event usages
([#3330](#3330))
([c5657de](c5657de))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2 participants