fix(sbb-radio-button-group): sync radios synchronously #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeripeierSBB
requested review from
TomMenga
and removed request for
kyubisation
github-actions
bot
added
the
pr: peer review required
TomMenga
requested changes
Dec 20, 2024
Comment on lines
74
to
80
| it('should respect disabled radio in value getter', async () => { | ||
| const radio = radios[0]; | ||
| radio.checked = true; | ||
| radio.disabled = true; | ||
| await waitForLitRender(element); | ||
|
|
||
| expect(element.value).to.be.null; | ||
| expect(element.value).to.be.equal('Value one'); |
There was a problem hiding this comment.
Do you think this is the desired behavior? Natively, the FormData would be empty in this case
There was a problem hiding this comment.
Is it the same? Here it is the group while native there is no group?
There was a problem hiding this comment.
My doubt is, should the group.value consider disabled radios?
In this case, both the native and our implementation would return an empty FormData (as if nothing were selected).
Meanwhile the sbb-radio-group returns Value one. I feel it is inconsistent :/
github-actions
bot
removed
the
pr: peer review required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3316