Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

story(sbb-header): removal of logo slot #3093

Closed
jeripeierSBB opened this issue Sep 18, 2024 · 0 comments · Fixed by #3230
Closed

story(sbb-header): removal of logo slot #3093

jeripeierSBB opened this issue Sep 18, 2024 · 0 comments · Fixed by #3230
Assignees
@TomMenga
Milestone
Release 2.0.0

Comments

@jeripeierSBB
Copy link
Contributor

We want to remove the logo slot of the header as a breaking change.

  • Links should still be styled correctly.
  • The space between logo and other content should be provided by a helper class
@jeripeierSBB jeripeierSBB converted this from a draft issue Sep 18, 2024
@jeripeierSBB jeripeierSBB added this to the Release 2.0.0 milestone Sep 18, 2024
@jeripeierSBB jeripeierSBB moved this from To do to Next in ESTA Web Lyne Design System Oct 28, 2024
@TomMenga TomMenga self-assigned this Nov 21, 2024
@TomMenga TomMenga moved this from Next to In progress in ESTA Web Lyne Design System Nov 21, 2024
@TomMenga TomMenga mentioned this issue Nov 22, 2024
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in ESTA Web Lyne Design System Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomMenga TomMenga

Labels
None yet
Projects
ESTA Web Lyne Design System
Archived in project
Milestone
Release 2.0.0
Development

Successfully merging a pull request may close this issue.

refactor(sbb-header): removed 'logo' slot sbb-design-systems/lyne-components
2 participants
@TomMenga @jeripeierSBB