Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

story: AI generated Chip #3090

Closed
mcilurzo opened this issue Sep 18, 2024 · 0 comments · Fixed by #3200
Closed

story: AI generated Chip #3090

mcilurzo opened this issue Sep 18, 2024 · 0 comments · Fixed by #3200
Assignees
Labels
complexity: M Can be done in a few days proposal: accepted
Milestone

Comments

@mcilurzo
Copy link
Contributor

mcilurzo commented Sep 18, 2024

There should be support to place a sbb-chip over an image to indicate AI generated content.

Design: https://www.figma.com/design/9r6xSfNmEfCFxl1yFYedrj/Lyne-Components?node-id=44805-55260&node-type=frame&t=hHul00mOPLODOhRD-11

In order to enable this, we create a breaking refactoring, whereas main goal is to extract non-image-cdn related stuff from the sbb-image where possible. All the styling should happen with CSS classes which can be applied tosbb-image and native img tag.

  • <figure> and <figcaption> should not be part anymore of the sbb-image. If there was a caption used, the consumer has to create it themself.

    <figure class="sbb-figure">
      <sbb-image ...></sbb-image> or <img />
      <figcaption>Caption</figcaption>
    </figure>
  • With the CSS class sbb-figure we want to provide the necessary styling.

  • For the <sbb-image> and the <img> we want to provide predefined CSS classes for border-radius (standard and round) and aspect ratio (all planned combinations).

  • If possible, the <figure> should use CSS grid so we can create CSS classes to position the AI generated chip on top by assigning the same grid area (See https://dev.to/nicm42/using-css-grid-to-put-elements-on-top-of-each-other-44ei). There should be one class for start start and one for end end positioning (naming pending :-) ).

    <figure class="sbb-figure">
      <sbb-image></sbb-image>
      <sbb-chip class="sbb-figure-chip-start-start"></sbb-chip>
      <figcaption>Caption</figcaption>
    </figure>
@mcilurzo mcilurzo converted this from a draft issue Sep 18, 2024
@mcilurzo mcilurzo self-assigned this Sep 18, 2024
@jeripeierSBB jeripeierSBB changed the title AI generated Chip story: AI generated Chip Oct 17, 2024
@jeripeierSBB jeripeierSBB added this to the Release 2.0.0 milestone Oct 17, 2024
@kyubisation kyubisation added proposal: accepted complexity: M Can be done in a few days and removed proposal: open labels Oct 21, 2024
@kyubisation kyubisation moved this from UX to Next in ESTA Web Lyne Design System Oct 21, 2024
@TomMenga TomMenga self-assigned this Oct 23, 2024
@TomMenga TomMenga moved this from Next to In progress in ESTA Web Lyne Design System Oct 23, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in ESTA Web Lyne Design System Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: M Can be done in a few days proposal: accepted
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants