Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: extract button styles to mixin #3075

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

style: extract button styles to mixin #3075

wants to merge 4 commits into from
+269 −110

Conversation

DavideMininni-Fincons
Copy link
Contributor

Preflight Checklist

Issue

This PR Closes #

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot temporarily deployed to pr3075 September 10, 2024 15:51 Inactive
@github-actions github-actions bot temporarily deployed to pr3075-diff September 10, 2024 15:51 Inactive
@DavideMininni-Fincons DavideMininni-Fincons changed the title style: extract button styles to mixin [WIP] style: extract button styles to mixin Sep 11, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Sep 11, 2024
@TomMenga TomMenga linked an issue Sep 20, 2024 that may be closed by this pull request
feat: extract button styles to mixin #3039
Open
@jeripeierSBB jeripeierSBB added the pr: blocked Pull request is blocked either for merging or reviewing label Sep 26, 2024
@jeripeierSBB
Copy link
Contributor

Currently blocked, as @jeripeierSBB is doing a button refactoring first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

@jeripeierSBB jeripeierSBB Awaiting requested review from jeripeierSBB jeripeierSBB is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
diff-available pr: blocked Pull request is blocked either for merging or reviewing pr: peer review required A peer review is required for this pull request pr: visual review required target: 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: extract button styles to mixin
3 participants
@DavideMininni-Fincons @jeripeierSBB @kyubisation