Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(sbb-select): SSR test fails providing a value to sbb-select #3021

Closed
DavideMininni-Fincons opened this issue Aug 23, 2024 · 0 comments · Fixed by #3027
Closed

bug(sbb-select): SSR test fails providing a value to sbb-select #3021

DavideMininni-Fincons opened this issue Aug 23, 2024 · 0 comments · Fixed by #3027
Assignees
@jeripeierSBB

Comments

@DavideMininni-Fincons
Copy link
Contributor

DavideMininni-Fincons commented Aug 23, 2024 •
edited
Loading

https://github.com/sbb-design-systems/lyne-components/tree/fix/bug-ssr-select-value

Adding a value in SSR tests as in commit 890d8e2 breaks the tests.

Both the connectedCallback and the willUpdate hooks call the _onValueChanged method, which asks for the sbb-options to match the provided value against them. The querySelectorAll fails in SSR, so the mismatch in the rendered displayValue.

Fix needed to resolve comment #2982 (comment)
@DavideMininni-Fincons DavideMininni-Fincons converted this from a draft issue Aug 23, 2024
@DavideMininni-Fincons DavideMininni-Fincons changed the title sbb-select - ssr bug SSR test fails providing a value to sbb-select Aug 23, 2024
Merged
28 tasks
@jeripeierSBB jeripeierSBB changed the title SSR test fails providing a value to sbb-select bug(sbb-select): SSR test fails providing a value to sbb-select Aug 26, 2024
@jeripeierSBB jeripeierSBB self-assigned this Aug 26, 2024
@jeripeierSBB jeripeierSBB linked a pull request Aug 26, 2024 that will close this issue
fix(sbb-select): fix display value in SSR context #3027
Merged
@jeripeierSBB jeripeierSBB mentioned this issue Aug 26, 2024
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in ESTA Web Lyne Design System Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeripeierSBB jeripeierSBB

Labels
None yet
Projects
ESTA Web Lyne Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sbb-select): fix display value in SSR context sbb-design-systems/lyne-components
2 participants
@jeripeierSBB @DavideMininni-Fincons