Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

story(sbb-container): add slot for background image #2963

Closed
5 tasks
kyubisation opened this issue Jul 25, 2024 · 0 comments · Fixed by #2999
Closed
5 tasks

story(sbb-container): add slot for background image #2963

kyubisation opened this issue Jul 25, 2024 · 0 comments · Fixed by #2999
Assignees
@MarioCastigliano
Labels
complexity: S Can be done in about a day proposal: accepted

Comments

@kyubisation
Copy link
Contributor

kyubisation commented Jul 25, 2024 •
edited
Loading

Feature Description

We want to enable using a sbb-image, img or any other kind of image as a background image in a sbb-container.

Figma: https://www.figma.com/design/9r6xSfNmEfCFxl1yFYedrj/Lyne-Components?m=auto&t=UXNBTHQ9k5uTf5ZT-1

Closes #2854

Tech spec:

  • Add slot image which is displayed in the background starting from the top and it should not stretch vertically
  • To discuss with @mcilurzo: Should the padding change when using this slot?

Definition of Done

  • Feature is implemented
  • Documentation is provided
  • Tests are implemented
  • Storybook stories are implemented
  • UX approved
@kyubisation kyubisation moved this from Funnel to Next in ESTA Web Lyne Design System Jul 25, 2024
@kyubisation kyubisation added proposal: accepted complexity: S Can be done in about a day and removed proposal: open labels Jul 26, 2024
@MarioCastigliano MarioCastigliano self-assigned this Aug 2, 2024
@MarioCastigliano MarioCastigliano moved this from Next to In progress in ESTA Web Lyne Design System Aug 2, 2024
@MarioCastigliano MarioCastigliano mentioned this issue Aug 14, 2024
Merged
28 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in ESTA Web Lyne Design System Aug 15, 2024
@jeripeierSBB jeripeierSBB mentioned this issue Aug 15, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarioCastigliano MarioCastigliano

Labels
complexity: S Can be done in about a day proposal: accepted
Projects
ESTA Web Lyne Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sbb-container): support for background image sbb-design-systems/lyne-components
2 participants
@kyubisation @MarioCastigliano