Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-status): add new types #2939

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Jul 15, 2024

Preflight Checklist

Issue

This PR Closes #2758

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • add four new states for the sbb-status component

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot temporarily deployed to pr2939 July 15, 2024 15:41 Inactive
@github-actions github-actions bot temporarily deployed to pr2939-diff July 15, 2024 15:42 Inactive
@github-actions github-actions bot temporarily deployed to pr2939 July 16, 2024 08:00 Inactive
@github-actions github-actions bot temporarily deployed to pr2939-diff July 16, 2024 08:01 Inactive
@DavideMininni-Fincons DavideMininni-Fincons changed the title feat(sbb-status): add new types [WIP] feat(sbb-status): add new types Jul 16, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jul 16, 2024
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Nice work!

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jul 17, 2024
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Jul 17, 2024
@DavideMininni-Fincons DavideMininni-Fincons merged commit 9e44f2a into main Jul 17, 2024
23 of 24 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the feat/status-add-states branch July 17, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: visual review required preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status: More status (color & icon)
3 participants