fix(various): ensure slotchange event is handled properly in hydration #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: peer review required
github-actions
bot
added
preview-available
pr: visual review required
diff-available
labels
jeripeierSBB
approved these changes
Jul 8, 2024
github-actions
bot
added
the
pr: lead review approved
|
Not sure, as I don't think we can differentiate between initializing and updating call. Or do you have an idea? (Also asked via Teams.) |
|
Discussed via Teams; Linting rule not possible. |
github-actions
bot
removed
the
pr: peer review required
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In components that have a
slotchangeevent handler for an initialization and no fallback, we need to use theSbbHydrationMixinto ensure theslotchangeevent is fired even with declarative Shadow DOM.