Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: focus on disabled buttons #2862

Closed
3 tasks done
LEGlism opened this issue Jul 1, 2024 · 2 comments · Fixed by #3040
Closed
3 tasks done

[Bug]: focus on disabled buttons #2862

LEGlism opened this issue Jul 1, 2024 · 2 comments · Fixed by #3040
Assignees
Labels
complexity: M Can be done in a few days type: bug 🐛 Something isn't working

Comments

@LEGlism
Copy link

LEGlism commented Jul 1, 2024

Preflight Checklist

Bug type

Accessibility

It affects the following packages

Components

Which version of Lyne Components are you using

1.2.0

Operating system

Windows 10

Browser / Browser version

Chrome 126.0.6478.127

Input mode

Mouse/Keyboard

Additional settings

No response

What happened?

At this moment disabled Buttons are not focusable for blind users. You can overwrite this with the tabIndex but this is not working in the DialogActions.
They should be focusable aswell, so that blind users can get information about the status.
I think there should be a prop to make this possible.

Steps to reproduce the issue

  1. disabled button on view
  2. try to tab to a button
    you cant tab to the disabled button

Relevant log output

No response


Implementation Details

  • Remove tabindex logic for disabled buttons (all types of buttons, but not form elements)
  • Add accessibility documentation for button components to recommend adding aria references to describe why the button is disabled (from consumer side)
@LEGlism LEGlism added the type: bug 🐛 Something isn't working label Jul 1, 2024
@LEGlism LEGlism changed the title [Bug]: [Bug]: focus on disabled buttons Jul 1, 2024
@kyubisation
Copy link
Contributor

Quick update: We are considering changing the implementation, but first we need to research the topic not to make it worse.

@kyubisation kyubisation added the complexity: M Can be done in a few days label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: M Can be done in a few days type: bug 🐛 Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants