Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sbb-notification): avoid resizeObserver loop warning #2855

Merged
merged 11 commits into from
Jul 3, 2024
Merged

fix(sbb-notification): avoid resizeObserver loop warning #2855

merged 11 commits into from
Jul 3, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

See fixme

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 28, 2024
@DavideMininni-Fincons DavideMininni-Fincons changed the title test: add visual test (see fixme) test(sbb-notification): add visual tests Jun 28, 2024
@DavideMininni-Fincons DavideMininni-Fincons mentioned this pull request Jun 28, 2024
Closed
71 tasks
@github-actions github-actions bot temporarily deployed to pr2855 June 28, 2024 14:11 Inactive
@github-actions github-actions bot temporarily deployed to pr2855 June 28, 2024 16:07 Inactive
@github-actions github-actions bot temporarily deployed to pr2855 July 1, 2024 13:16 Inactive
@github-actions github-actions bot temporarily deployed to pr2855 July 2, 2024 09:32 Inactive
@github-actions github-actions bot temporarily deployed to pr2855 July 2, 2024 13:20 Inactive
jeripeierSBB
jeripeierSBB approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jul 3, 2024
@jeripeierSBB jeripeierSBB changed the title test(sbb-notification): add visual tests fix(sbb-notification): avoid resizeObserver loop warning Jul 3, 2024
@github-actions github-actions bot temporarily deployed to pr2855 July 3, 2024 07:53 Inactive
@DavideMininni-Fincons DavideMininni-Fincons merged commit 6222b25 into main Jul 3, 2024
21 of 22 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the feat/migration-notification branch July 3, 2024 09:00
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Jul 3, 2024
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
Merged
This was referenced Nov 4, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@TomMenga TomMenga Awaiting requested review from TomMenga

@MarioCastigliano MarioCastigliano Awaiting requested review from MarioCastigliano

@dauriamarco dauriamarco Awaiting requested review from dauriamarco

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavideMininni-Fincons @jeripeierSBB