Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: turn getValueAsDate/setValueAsDate into a get/set property #2223

Closed
DavideMininni-Fincons opened this issue Nov 23, 2023 · 0 comments · Fixed by #2244
Closed

refactor: turn getValueAsDate/setValueAsDate into a get/set property #2223

DavideMininni-Fincons opened this issue Nov 23, 2023 · 0 comments · Fixed by #2244
Assignees
@DavideMininni-Fincons

Comments

@DavideMininni-Fincons
Copy link
Contributor

Convert getValueAsDate/setValueAsDate into a get/set property valueAsDate (sbb-time-input and sbb-datepicker).
Proposal: use a couple of get/set properties (value, valueAsDate) just like on native input elements in order to avoid ambiguous scenarios like timeInput.valueAsDate = “2024-10-10T09:00:00.000Z”.
@DavideMininni-Fincons DavideMininni-Fincons converted this from a draft issue Nov 23, 2023
@DavideMininni-Fincons DavideMininni-Fincons self-assigned this Nov 23, 2023
@DavideMininni-Fincons DavideMininni-Fincons linked a pull request Nov 29, 2023 that will close this issue
fix(sbb-time-input): create get/set for valueAsDate #2244
Merged
Merged
@jeripeierSBB jeripeierSBB moved this from Funnel to Pull Requests in ESTA Web Lyne Design System May 15, 2024
@jeripeierSBB jeripeierSBB moved this from Pull Requests to In progress in ESTA Web Lyne Design System May 15, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in ESTA Web Lyne Design System Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavideMininni-Fincons DavideMininni-Fincons

Labels
None yet
Projects
ESTA Web Lyne Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sbb-time-input): create get/set for valueAsDate sbb-design-systems/lyne-components
1 participant
@DavideMininni-Fincons