From f3494636331ed2b1437816d57ffc94fe5d7a93f1 Mon Sep 17 00:00:00 2001 From: Jeri Peier Date: Mon, 23 Sep 2024 13:58:44 +0200 Subject: [PATCH] refactor: remove obsolete `getLocalName()` (#3110) --- src/elements/core/base-elements/action-base-element.ts | 7 +------ src/elements/core/base-elements/link-base-element.ts | 3 +-- src/elements/core/dom/ssr.ts | 2 ++ src/elements/core/mixins/named-slot-list-mixin.ts | 6 ++---- 4 files changed, 6 insertions(+), 12 deletions(-) diff --git a/src/elements/core/base-elements/action-base-element.ts b/src/elements/core/base-elements/action-base-element.ts index ab9af4ce1e..35798c68fa 100644 --- a/src/elements/core/base-elements/action-base-element.ts +++ b/src/elements/core/base-elements/action-base-element.ts @@ -1,7 +1,6 @@ import { html, LitElement, type TemplateResult } from 'lit'; import { hostAttributes } from '../decorators.js'; -import { getLocalName } from '../dom.js'; /** * Whenever an element can be disabled it has disabled property @@ -64,10 +63,6 @@ export abstract class SbbActionBaseElement extends LitElement { /** Default render method for button-like components. */ protected override render(): TemplateResult { - return html` - - ${this.renderTemplate()} - - `; + return html` ${this.renderTemplate()} `; } } diff --git a/src/elements/core/base-elements/link-base-element.ts b/src/elements/core/base-elements/link-base-element.ts index f1e2019152..1ba733007d 100644 --- a/src/elements/core/base-elements/link-base-element.ts +++ b/src/elements/core/base-elements/link-base-element.ts @@ -3,7 +3,6 @@ import { property } from 'lit/decorators.js'; import { SbbLanguageController } from '../controllers.js'; import { hostAttributes } from '../decorators.js'; -import { getLocalName } from '../dom.js'; import { i18nTargetOpensInNewWindow } from '../i18n.js'; import { SbbActionBaseElement } from './action-base-element.js'; @@ -65,7 +64,7 @@ export abstract class SbbLinkBaseElement extends SbbActionBaseElement { protected override render(): TemplateResult { return html` (); * https://github.com/lit/lit/blob/main/packages/labs/ssr-dom-shim/src.ts (See CustomElementRegistryShim) * * Can be removed once https://github.com/lit/lit/pull/4553 is merged/released. + * + * @deprecated Will be removed with next major version */ export function getLocalName(element: LitElement): string { if (localNameCache.has(element.constructor)) { diff --git a/src/elements/core/mixins/named-slot-list-mixin.ts b/src/elements/core/mixins/named-slot-list-mixin.ts index 29b868ef69..45e24435e6 100644 --- a/src/elements/core/mixins/named-slot-list-mixin.ts +++ b/src/elements/core/mixins/named-slot-list-mixin.ts @@ -1,8 +1,6 @@ import { html, type LitElement, nothing, type TemplateResult } from 'lit'; import { state } from 'lit/decorators.js'; -import { getLocalName } from '../dom.js'; - import type { AbstractConstructor } from './constructor.js'; import { SbbHydrationMixin, type SbbHydrationMixinType } from './hydration-mixin.js'; @@ -130,7 +128,7 @@ export const SbbNamedSlotListMixin = < if (listSlotNames.length >= 2) { return html`