Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs: puma 6 compatibility #979

Closed
pcai opened this issue Oct 14, 2022 · 0 comments · Fixed by #983
Closed

specs: puma 6 compatibility #979

pcai opened this issue Oct 14, 2022 · 0 comments · Fixed by #983

Comments

@pcai
Copy link
Member

pcai commented Oct 14, 2022

Bug report

Current behavior:
specs fail with puma 6

Steps to reproduce current behavior:

bundle exec rspec in master:

...
       Failure/Error: Puma::Events.new($stdout, $stderr)

       ArgumentError:
         wrong number of arguments (given 2, expected 0)
       # ./vendor/bundle/ruby/2.7.0/gems/puma-6.0.0/lib/puma/events.rb:11:in `initialize'
       # ./spec/integration/support/server.rb:62:in `new'
       # ./spec/integration/support/server.rb:62:in `events'
       # ./spec/integration/support/server.rb:31:in `initialize'
       # ./spec/integration/support/server.rb:10:in `new'
       # ./spec/integration/support/server.rb:10:in `run'
       # ./spec/savon/options_spec.rb:11:in `block (2 levels) in <top (required)>'

Expected behavior:

tests pass

System information:

  • ruby version: all
  • savon version: 2.13.1 // master
@pcai pcai mentioned this issue Oct 14, 2022
@pcai pcai closed this as completed in #983 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant