Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rack 3.0 support #236

Closed
pcai opened this issue Sep 21, 2022 · 1 comment
Closed

rack 3.0 support #236

pcai opened this issue Sep 21, 2022 · 1 comment

Comments

@pcai
Copy link
Member

pcai commented Sep 21, 2022

https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md includes many breaking changes. httpi explicitly depends on rack, and also uses it as part of its own public interface. Unfortunately, this interface has now changed in rack.

In rack 3, headers must be all lowercase. in rack 2, they don't have to be. so if we want to support rack 3, it appears we require a major breaking change to a public method HTTPI::Request#headers

This is only one example. There are very likely other breaking changes that affect httpi; I have not exhaustively reviewed their impact yet.

@pcai
Copy link
Member Author

pcai commented Mar 27, 2023

per #238 we would prefer to dedicate our efforts towards a migration to faraday rather than work on new features, closing

@pcai pcai closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant