Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive renaming and removing of useless things #2904

Open
orchestr7 opened this issue Jan 13, 2024 · 4 comments
Open

Massive renaming and removing of useless things #2904

orchestr7 opened this issue Jan 13, 2024 · 4 comments
Assignees

Comments

@orchestr7
Copy link
Member

orchestr7 commented Jan 13, 2024

We should do a lot of renaming and removal of legacy shit.

  1. Rename all packages:
    • remove save and save-cloud prefixes completely for common modules. It can only be: save/cosv-common (ONLY for SAVE/COSV specific common, in terms of Kotlin MPP for Native + JVM + JS), common (MPP for JS + JVM which are used EVERYWHERE), common-frontend (JS only code shared between COSV, SAVE, etc.) and common-backend (JVM only logic shared between COSV, SAVE, if needed). save-common should NOT be used in ANY COSV module as well as cosv-common cannot be used in SAVE.
    • we should have cosv-frontend, save-frontend and save-backend, cosv-backend. For save-specific components it is ok to have save-orchestrator, save-agent, etc.;
    • rename packages:
      • COSV and common packages should NOT have save in it's name
      • save-cloud-common packages should be renamed to com.saveourtool.common
      • cosv-backend instead of com.saveourtool.save.cosv.repository should be named as com.saveourtool.cosv.repository
  2. Remove sandbox service (if someone wishes to have - can save in separate repository later);
  3. After the removal of sandbox service - merge orchestrator-common with save-orchestrator;
@orchestr7
Copy link
Member Author

@nulls if you will have any other ideas - welcome to share

@nulls
Copy link
Member

nulls commented Jan 15, 2024

@nulls if you will have any other ideas - welcome to share

  1. Removing sandbox and merging save-orchestator-common with save-orchestrator can be done before renaming to reduce affected files
  2. Suggestion to create a tag before renaming (or a branch at least)
  3. We have save-cloud-charts, probably we need to split it too
  4. What's about api-gateway and authentication-service? They are required for COSV and SAVE. Do we need to rename packages there?

@orchestr7
Copy link
Member Author

  1. What's about api-gateway and authentication-service? They are required for COSV and SAVE. Do we need to rename packages there?

Yeah, need to rename their packages as well! com.saveourtool.api-gateway

@Cheshiriks
Copy link
Member

We also need to rename the paths for entities in save-cloud-common

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants