Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive finding for USE_DATA_CLASS rule on @Stable annotated class #1316

Closed
WebTiger89 opened this issue May 27, 2022 · 2 comments
Closed

False positive finding for USE_DATA_CLASS rule on @Stable annotated class #1316

WebTiger89 opened this issue May 27, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@WebTiger89
Copy link

WebTiger89 commented May 27, 2022 •
edited by orchestr7
Loading

@Stable is an android/Jetpack Compose construct

The suspicious code snippet:

@Stable
class PermissionState {
    var showRationale by mutableStateOf(false)
}
@WebTiger89 WebTiger89 added the bug Something isn't working label May 27, 2022
@orchestr7 orchestr7 added help wanted Extra attention is needed good first issue Good for newcomers enhancement New feature or request and removed bug Something isn't working labels May 27, 2022
@petertrr
Copy link
Member

I think it's another case #802. We should definitely support a configurable set of excludes for this rule.

@orchestr7
Copy link
Member

I think it's another case #802. We should definitely support a configurable set of excludes for this rule.
Yes, duplicate of #802

@orchestr7 orchestr7 mentioned this issue May 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@petertrr @WebTiger89 @orchestr7