-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incosistency in the CityGML dataset #5
Comments
great @OloOcki! Do we also need to update the creation guidelines regarding the discovered inconsistencies? |
I guess that it would be nice to have a short list of things that have to be carefully examined. Likes of empty/not empty geometry check, homogeneity check among others. I guess that a list of possible inconsistencies might expand together with the project's expansion. I recommend to create a FME workspace that will be capable to perform validation of consistency (especially focusing on the geometry but also semantics) and attach it to the repo. The workflow should evolve with the project. |
Thank you for the thread @OloOcki! Is it correct that e.g. "line UUID_6773c2e8-ba0d-4680-897c-26490ea6c1fc_BP.w8OJH2XnTm8nLMOllRO6 outerBuildingInstallation" indicates that this should be assigned to outerBuildingInstallation, which at the moment is not the case? |
@Sophie876 for now the aforementioned logs are just to point out where a problem exists without a detailed description. I totally agree that it is rather hard to understand the meaning behind them. Thus, the planned validating tool in a FME workspace should provide more meaningful logs. Thanks for your feedback! At the very beginning the dataset was created without a geometrical representation in a Building class. Thus, this class should be empty w.r.t. geometry. For example, id201 is an unique ID of a Building and it contains a geometry (line). This is an incosistency in the dataset and stands as a problem for further processing. The question regarding the UUID_6773c2e8-ba0d-4680-897c-26490ea6c1fc_BP.w8OJH2XnTm8nLMOllRO6 ID means that there are multiple geometries present (lines + surfaces) in the class which is not desired. The geometry should be homogen (in our case only surfaces). |
This is a threat concerning inconsistency within the presented CityGML dataset. The threat will be updated periodically.
Albeit great effort to ensure geometrical and semantical consistency in modeling there could be some deviations present within the model. Thus, here is the list of things to be fixed:
Remap geometry:
The text was updated successfully, but these errors were encountered: