Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

martian: res.Close should not be passed downstream #684

Closed
mmatczuk opened this issue Feb 8, 2024 · 0 comments · Fixed by #724
Closed

martian: res.Close should not be passed downstream #684

mmatczuk opened this issue Feb 8, 2024 · 0 comments · Fixed by #724
Labels
bug Something isn't working
Milestone

Comments

@mmatczuk
Copy link
Contributor

mmatczuk commented Feb 8, 2024

We should always clear res.Close status flag and never close downstream connection due to upstream connection closing.

Example

proxy-1    | GET http://httpbin:8080/status/200 HTTP/1.1
proxy-1    | Host: httpbin:8080
proxy-1    | Content-Length: 0
proxy-1    | Accept-Encoding: gzip
proxy-1    | User-Agent: Go-http-client/1.1
proxy-1    | Via: 1.1 forwarder-d1cf0cb277b1325ce65b
proxy-1    | X-Forwarded-For: 10.89.0.241
proxy-1    | X-Forwarded-Host: httpbin:8080
proxy-1    | X-Forwarded-Proto: http
proxy-1    | X-Forwarded-Url: http://httpbin:8080/status/200
proxy-1    | 
proxy-1    | HTTP/1.0 400 Bad Request
proxy-1    | Test-Resp-Add: test-resp-value
proxy-1    | 
proxy-1    | 
proxy-1    | 2024/02/08 13:59:28.163077 [proxy] [DEBUG] [5-d3741bcd] received close request: 10.89.0.241:42202
proxy-1    | 2024/02/08 13:59:28.163155 [proxy] [DEBUG] closing connection: 10.89.0.241:42202

Upstream and Downstream connections are separate and we should not propagate the close.

@mmatczuk mmatczuk added the bug Something isn't working label Feb 8, 2024
@mmatczuk mmatczuk added this to the v1.2 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant