PercentAbove includes NA's as if above threshold

[molecules]

Heads up, I found out that if NAs are included, then they are counted as above the threshold.

For example, I would expect that given one value at the threshold and some NAs, that the "PercentAbove" would return 0. However, as you can see, the following code counts all NAs as being above the threshold.

> a <- c(1, NA, NA)
> PercentAbove(a, threshold = 1)
[1] 0.6666667

seurat/R/utilities.R

Lines 1129 to 1131 in 41d19a8

	PercentAbove <- function(x, threshold) {
	return(length(x = x[x > threshold]) / length(x = x))
	}

[longmanz]

Hi,
Thank you for pointing this out. This is indeed a bug, and it could potentially affect DotPlot(). We will fix it.

[Gesmira]

Hi,
This is now resolved in the most recent version of Seurat. Please feel free to reopen if you continue to run into any problems. Thanks!