Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateSymbolList generates wrong symbols #4545

Closed
apredeus opened this issue May 27, 2021 · 2 comments
Closed

UpdateSymbolList generates wrong symbols #4545

apredeus opened this issue May 27, 2021 · 2 comments
Labels
bug Something isn't working more-information-needed We need more information before this can be addressed

Comments

@apredeus
Copy link

Dear Seurat team,

It seems like UpdateSymbolList uses a logic that results in erroneous changes to some gene symbols.

There are quite a few genes for which official HGNC symbol co-insides with a symbol that was used for another gene in the past. The function automatically changes these. For example, HBM is a current name for "hemoglobin subunit mu", and an old name for "LDL receptor related protein 5", which are two totally different genes (https://www.genenames.org/tools/search/#!/?query=HBM). The function, however, converts HBM to LRP5. Similar thing happens to HBG1 and quite a few other genes.

I think there needs to be a check if gene symbol exists in the newest version - and if it does, the symbol should not be changed.

@apredeus apredeus added the bug Something isn't working label May 27, 2021
@andrewwbutler
Copy link
Collaborator

Hi,

Thanks for reporting! We've made some fixes/updates to this function which hopefully resolve this problem. Please try installing the develop branch (instructions here) and see if that fixes the issue for you.

@andrewwbutler andrewwbutler added the more-information-needed We need more information before this can be addressed label Jun 2, 2021
@no-response
Copy link

no-response bot commented Jun 16, 2021

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working more-information-needed We need more information before this can be addressed
Projects
None yet
Development

No branches or pull requests

2 participants