From 587a7f67d557214c86d8f4fe020be73aa5789e3a Mon Sep 17 00:00:00 2001 From: "noa.santo" Date: Mon, 9 Sep 2024 16:43:22 +0200 Subject: [PATCH 1/2] fix (a11y): add aria hidden to NavigationFlyout when visually hidden --- src/components/layout/header/menu-flyout.tsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/components/layout/header/menu-flyout.tsx b/src/components/layout/header/menu-flyout.tsx index e76dce186..63db1ead0 100644 --- a/src/components/layout/header/menu-flyout.tsx +++ b/src/components/layout/header/menu-flyout.tsx @@ -65,7 +65,11 @@ interface NavigationFlyoutProp { export const NavigationFlyout: React.FC = (props) => { return ( <> - + = (props) => { props.setIsNavigationVisible(false)} + aria-hidden={!props.visible} /> ); From 0788154ca14db2135d5e33fc9f91eadede17b0b3 Mon Sep 17 00:00:00 2001 From: "noa.santo" Date: Tue, 10 Sep 2024 16:45:36 +0200 Subject: [PATCH 2/2] fix (a11y): remove unnecessary aria-hidden from background overlay --- src/components/layout/header/menu-flyout.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/layout/header/menu-flyout.tsx b/src/components/layout/header/menu-flyout.tsx index 63db1ead0..4c536eeb3 100644 --- a/src/components/layout/header/menu-flyout.tsx +++ b/src/components/layout/header/menu-flyout.tsx @@ -81,7 +81,6 @@ export const NavigationFlyout: React.FC = (props) => { props.setIsNavigationVisible(false)} - aria-hidden={!props.visible} /> );