Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proc python auto-indent #1377

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Conversation

scnwwu
Copy link
Member

@scnwwu scnwwu commented Jan 24, 2025

Summary
Fix #1376

Testing
Test case in #1376

@scnwwu scnwwu requested review from boyce-w and bitaoz January 24, 2025 06:51
@scnwwu scnwwu added this to the 1.14.0 milestone Jan 24, 2025
@enzhihpp enzhihpp assigned Zhirong2022 and unassigned enzhihpp Jan 24, 2025
@Zhirong2022 Zhirong2022 added testing Test the pull requests and removed verification-needed labels Jan 24, 2025
@Zhirong2022
Copy link
Collaborator

Indentation does not work properly in following scenario.
Input code below, type Enter next to 'submit;' and type some Python code.

proc python;
    submit;
    endsubmit;
run;

image

@scnwwu
Copy link
Member Author

scnwwu commented Jan 27, 2025

Indentation does not work properly in following scenario. Input code below, type Enter next to 'submit;' and type some Python code.

proc python;
    submit;
    endsubmit;
run;

image

Let's focus on typing sequencially and no fix this case for now. Thanks.

@Zhirong2022 Zhirong2022 added testing-complete Complete the pull requests testing and removed testing Test the pull requests labels Jan 27, 2025
@scnwwu scnwwu merged commit f9092dc into sassoftware:main Jan 27, 2025
2 checks passed
@scnwwu scnwwu deleted the p-pythonindentation branch January 27, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing-complete Complete the pull requests testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indentation improvement for the typed python code line following 'submit;' in PROC PYTHON code block
5 participants