You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
I'm very happy with the choice and use of prebuild, so it's a +1 from me.
People are always going to misdirect complaints about badly-configured corporate proxies towards open source maintainers, so that noise never really goes away, sorry.
Before you do this I highly recommend migrating from nan to N-API via node-addon-api and only support one version of N-API at a time (e.g. sharp only provides N-API v3), which then means you no longer require separate electron binaries or need to "rebuild".
@lovell appreciate the response! @xzyfer had taken a look at the N-API stuff a little while ago with #2440, but I'd like to just do an initial cutover and cleanup of our custom binary distribution first. It definitely does seem like a better way to go though.
I noticed that your repo is licensed under Apache 2. Do you need some sort of license distribution or is an acknowledgement OK if I try to base a new binary setup based off your pattern there?
@nschonni Please feel free to borrow as much as you can from sharp. Apache 2.0 is permissive so derivatives can use a different licence, but yes, attribution is still required, thank you.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Came across this while looking around at options for the Electron building
I'll try to kick the tires a bit, but is it worth trying to change for the next release or wait till after?
The text was updated successfully, but these errors were encountered: