Support Node 8

[xzyfer]

Tracking issue for Node 8 support to stop all the duplicate issues. Support was added in 4.5.3 but the binaries still need to be built.

• OS X x64 (@xzyfer)
• Linux x86 (@xzyfer)
• Linux x64 (@xzyfer)
• Alpine (@xzyfer)
• Windows x86 (@nschonni)
• Windows x64 (@nschonni)

Please don't comment, there nothing to add to this issue. To stay updated clicked the subscribe button on the right --->

[xzyfer]

@am11 are you able to build the Windows binaries whilst we wait for AppVeyor to catch up please?

[nschonni]

Fudged the appveyor to get it to produce the bindings, just waiting on the queue https://ci.appveyor.com/project/sass/node-sass/build/2531

[nschonni]

@xzyfer windows bindings are done

[xzyfer]

Are you able to add binaries to releases?

[xzyfer]

I've hit a snag with the Linux binaries. We build them on CentOS 5 which recently EOL'd so our docker image isn't currently working.

[nschonni]

Yes, not sure if we're running into each other since i'm getting "binary already exists". I'll give it a few minutes in case you're doing it right now

[xzyfer]

I'm not touching releases atm.

[xzyfer]

I don't see it on the release so I can't explain that error.

[nschonni]

Think I tried to drag and drop a few and it choked. I'll just start over and ping this when i'm done

[nschonni]

Think my Firefox wasn't playing nice, but I got it uploaded with Edge

[xzyfer]

@nschonni if you've got time, I've been using https://github.com/lox/node-sass-build-alpine-binaries for building the Alpine binaries. These lines will need to be updated https://github.com/lox/node-sass-build-alpine-binaries/blob/master/build.sh#L4-L5

[nschonni]

HEAD is now at 48bbed1... 4.5.3
Generating Dockerfile.8
Building node-sass-alpine-builder:8
Sending build context to Docker daemon 18.72 MB
Step 1/8 : FROM node:8-alpine
manifest for node:8-alpine not found
Nicks-MacBook-Pro:node-sass-build-alpine-binaries nschonni$ 

Looks like the image for node 8 doesn't exist yet

[xzyfer]

This appears to be the upstream tracking issue for the alpine image update - nodejs/docker-node#411

[nschonni]

Trying https://hub.docker.com/r/mhart/alpine-node/ to see if it will work. It's running now

[nschonni]

Test seem to pass, but it is an Alpine 3.6 base. Should I upload it or wait for the official Node image to get fixed?

[xzyfer]

Upload it. I don't think Alpine gets that much use atm. Ideally we'd regenerate all the Alpine binaries with 3.6 to hopefully fix #1879

[nschonni]

Done, but it looks like it's half the size of the last one

[xzyfer]

Interesting. Well nodejs/docker-node#411 just got merged so we'll be able to confirm shortly.

[xzyfer]

The official Node 8 docker images are live. I'll try to sort out linux tonight.

[nschonni]

Did you figure out what the new base should be? I'm playing around with some dockerfiles to add to the repo and I'll add them in if you have

[xzyfer]

For the sake of safety I was going to try whatever the lowests supported centos is.

[nschonni]

Makes sense.
BTW, I built using the official Node image and the Apline binding was the same size. Maybe it's just improvements with the 3.6 image

[xzyfer]

Nice. I wonder if Alpine 3.6 resolves #1879. If I'd been keen to update all the existing Alpine binaries suing the mhart image.

[xzyfer]

I've created the linux binaries based of CentOS 6. I think they're legit. Is anyone able to confirm they work as expected?

[xzyfer]

Twitter says 👍 - https://twitter.com/ckotzbauer1/status/870283705398571008