Support iojs v3

[xzyfer]

iojs v3 was released today, this means we need to update to nan v2 which has brought some massive breaking changes.

[saper]

Working on it.

[andreimc]

👍

[xzyfer]

I made a start on it today but there were no end to the errors. I'm speaking at some events the next couple of days but I'll come back to this over the weekend if you don't get anywhere @saper.

[saper]

I made a start on it today but there were no end to the errors. I'm speaking at some events the next couple of days but I'll come back to this over the weekend if you don't get anywhere @saper.

binding.cpp, create_string.cpp, custom_function_bridge.cpp are compiling fine for me now one problem left in custom_importer_bridge.cpp Looks not bad :)

[xzyfer]

@saper I look very forward to seeing your PR. I originally made the mistake of running the nan conversion tool. It made a real mess of things.

[kenips]

👍 thanks for the great news @saper

[saper]

@saper I look very forward to seeing your PR. I originally made the mistake of running the nan conversion tool. It made a real mess of things.

I did that, too, but somehow managed to fixed the damage :)

[saper]

It now compiles, just crashes :)

[saper]

I am pushing commits to #1054 as I progress (https://github.com/saper/node-sass/tree/iojs45)

Currently I am stuck at the problem with creating instances of Color object:

https://travis-ci.org/sass/node-sass/jobs/74343260

#8  0x0000000802d492de in Nan::SetInternalFieldPointer (object=..., index=0, value=0x803419740) at ../node_modules/nan/nan.h:575
#9  0x0000000802d55a8b in SassTypes::SassValueWrapper<SassTypes::Color>::New (info=...) at ../src/sass_types/sass_value_wrapper.h:124
#10 0x0000000802d417cd in Nan::imp::FunctionCallbackWrapper (info=...) at ../node_modules/nan/nan_callbacks_12_inl.h:167
#11 0x00000000007f45a5 in v8::internal::FunctionCallbackArguments::Call (this=0x7fffffff5840, 

info.This()->InternalFieldCount() at this time is 0, which indicates an improperly constructed or deleted object.

Any help in troubleshooting this welcome :)

[saper]

node 0.10 seems to go further and crashes in cli.js tests:

https://travis-ci.org/sass/node-sass/jobs/74343257

What is interesting here is that we should probably have an api.js test as well to reproduce the problem.

[saper]

Above issues seem to be resolved, feel free to test #1054

[sc0ttwad3]

If this helps.. once upgrading to iojs 3.0.0...node-sass installation is failing as others have described...but of note is installation failing to download https://github.com/sass/node-sass/releases/download/v3.2.0/win32-x64-45_binding.node ... The releases only currently go up to win32-x64-44_binding.node

C:\Projects\Blog-Workspace\workspace {git}
npm install node-sass -g
C:\Users\swade\AppData\Roaming\npm\node-sass -> C:\Users\swade\AppData\Roaming\npm\node_modules\node-sass\bin\node-sass

> [email protected] install C:\Users\swade\AppData\Roaming\npm\node_modules\node-sass
> node scripts/install.js

Cannot download "https://github.com/sass/node-sass/releases/download/v3.2.0/win32-x64-45_binding.node": HTTP error 404 Not Found

> [email protected] postinstall C:\Users\swade\AppData\Roaming\npm\node_modules\node-sass
> node scripts/build.js

Building: C:\Program Files\iojs\node.exe node_modules\pangyp\bin\node-gyp rebuild --libsass_ext= --libsass_cflags= --libsass_ldflags= --    libsass_library=
gyp ERR! configure error
gyp ERR! stack Error: spawn C:\Python27 ENOENT
gyp ERR! stack     at exports._errnoException (util.js:812:11)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:178:32)
gyp ERR! stack     at onErrorNT (internal/child_process.js:344:16)
gyp ERR! stack     at doNTCallback2 (node.js:429:9)
gyp ERR! stack     at process._tickCallback (node.js:343:17)
gyp ERR! System Windows_NT 6.3.9600
gyp ERR! command "C:\\Program Files\\iojs\\node.exe" "C:\\Users\\swade\\AppData\\Roaming\\npm\\node_modules\\node-    sass\\node_modules\\pangyp\\bin\\node-gyp" "rebuild" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd C:\Users\swade\AppData\Roaming\npm\node_modules\node-sass
gyp ERR! node -v v3.0.0
gyp ERR! pangyp -v v2.2.1
gyp ERR! not ok
Build failed
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\\Program Files\\iojs\\node.exe" "C:\\Program Files\\iojs\\node_modules\\npm\\bin\\npm-cli.js" "install" "node-sass" "-g"
npm ERR! node v3.0.0
npm ERR! npm  v2.13.3
npm ERR! code ELIFECYCLE

npm ERR! [email protected] postinstall: `node scripts/build.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] postinstall script 'node scripts/build.js'.
npm ERR! This is most likely a problem with the node-sass package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node scripts/build.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls node-sass
npm ERR! There is likely additional logging output above.

[saper]

For testing, one needs to check out the modified code of node-sass in the source form (for example by using git clone --branch iojs45 https://github.com/saper/node-sass).

Then it is necessary to compile the code from source, npm install will not fetch the binary as we haven't tested those changes yet.

[devinus]

What's the status of this?

[saper]

Check out and test #1054

[devinus]

Thanks @saper

[saper]

@saper sorry I suppose I came off as pretty greedy or so... Not a budget issue, just felt very stressed out yesterday thinking I couldn't help (but still waiting on it.) That has now changed & I'm looking into installing it and testing. Let me know if I should do anything in particular!

Just use iojs 2.x if you can't wait.

[mull]

No I can wait, and I could try and help but my attempts have been feeble so far. I appreciate the work on this and sorry again if I came off as rude.

[xzyfer]

Fixed in #1054

[xzyfer]

This will be in 3.3.0

[gajus]

@xzyfer Thank you!

[mull]

Big thank you to all involved!

[Phoenixmatrix]

What is the process/timeline for the binaries to be available via npm install? (I'm unfamiliar with node-sass release process and trying to decide if we go with iojs 2.5 or just wait a little for this to go out).

Thanks for working so hard on this!

[devinus]

@Phoenixmatrix I would recommend going with 2.5 for awhile. It seems there are several packages still not quite ready for 3.0, and going with 2.5 for another month is going to be way less headache for now.

[gajus]

@devinus Is there a reason 3.3.0 release is being delated? Currently, node-sass is the only package thats keeping me from upgrading to iojs 3.0.0, and given my rather standard stack, I am sure I am not the only one.

[mgol]

@gajus Node.js 4.0.0 should be released in a few weeks, io.js 3 is kind of an alpha of it.

Also, note that it's already been answered in #1086 (comment) that a release should arrive within a few hours. But even if it's delayed a little further, it shouldn't matter too much given the imminent Node 4 release; you can always skip io.js 3 & upgrade directly to Node 4.

[gajus]

Given that several packages no longer support node at all (e.g. jsdom), going to node is not an option.

[saper]

@devinus Is there a reason 3.3.0 release is being delated? Currently, node-sass is the only package thats keeping me from upgrading to iojs 3.0.0, and given my rather standard stack, I am sure I am not the only one.

Please take into account that 1) node-sass is not an ordinary npm package - we have binary component that has to be compatible not only with JavaScript and node's JS APIs, but also with C++, V8 binary interfaces and libuv. 2) Even io.js programmers admit that changes in V8 versions 4.4 they are using now are far reaching and every binary module needs to review and modify most of their code again to talk to io.js properly. The work is now mostly done, you are invited to try git master from https://github.com/sass/node-sass for testing.

[gajus]

I am not rushing anyone. I am genuinely asking whether there are technical issues holding the release of v3.3.0. I am very grateful to everyone who contribute to this package. Thank you for the answer.

[saper]

I am not rushing anyone. I am genuinely asking whether there are technical issues holding the release of v3.3.0. I am very grateful to everyone who contribute to this package. Thank you for the answer.

No, not at the moment, we just need testing and packaging.

[mgol]

@gajus

Given that several packages no longer support node at all (e.g. jsdom), going to node is not an option.

I think you misunderstand the situation. jsdom doesn't support Node 0.10 & 0.12, it will work fine with Node 4. io.js will be dead with the release of Node 4, there will be no more io.js releases, the projects have merged.

Good news (compatibility-wise) is that Node 4 will use the same V8 version as io.js 3 so node-sass should automatically work fine with it when it starts working with io.js 3.

[gajus]

@mzgol I was not aware of that at all. Thank you for clarifying.

[thealjey]

@mzgol WOW, that does sound exciting!
However, I could not find anything about the upcoming Node.js 4.0.0 release on the internet. Could please you point me to wherever you've got this information from?
Thanks!

[saper]

However, I could not find anything about the upcoming Node.js 4.0.0 release on the internet. Could please you point me to wherever you've got this information from?

https://medium.com/node-js-javascript/4-0-is-the-new-1-0-386597a3436d

[xzyfer]

@devinus

Is there a reason 3.3.0 release is being delated?

Yes. The changes iojs 3 at the v8 were significant. This meant that we had to wait for packages we depend on to update, as well as then incorporating those changes into node-sass.

Secondly, although the new release is technically ready to go, I needed to sleep. Dropping a new release, going to bed and leaving y'all do deal with it l wasn't something I was prepared to do because I <3 you all.

Currently, node-sass is the only package thats keeping me from upgrading to iojs 3.0.0, and given my rather standard stack, I am sure I am not the only one.

Although this may be true for you, this is not an accurate reflection of the current iojs 3 landscape.

To support iojs 3 nan released a new major version. nan is the library used by most (all?) native node extensions like filesystem watchers and websocker servers. For us this meant we had to almost completely rewrite the c++ code that binds us to LibSass.

[devinus]

There are a ton of packages not ready for 3.0.0, node-sass was definitely not the only one.