to-upper-case strings being double-quoted in 3.2.0-beta.6

[sndrs]

using [email protected] on OS X, the following SCSS:

$s: to-upper-case('abcd');

p {
    content: '#{$s}';
    content: '#{unquote($s)}';
    content: '#{$s + unquote("efg")}';
    content: '#{$s + unquote("")}';
}

produces this CSS:

p {
  content: '"ABCD"';
  content: '"ABCD"';
  content: '"ABCD"efg';
  content: "ABCD"; 
}

I would have expected:

p {
  content: 'ABCD';
  content: 'ABCD';
  content: 'ABCDefg';
  content: 'ABCD'; 
}

I think this is a bug? Or have I just misunderstood?

[xzyfer]

I can confirm this is a regression in 3.2.0. Libsass 3.1.0 produced the expect output.

Correction Libsass 3.1.0 produced semantically correct output, but failed to normalise to double quotes.

[xzyfer]

Specs added sass/sass-spec#341

[xzyfer]

A git bisect shows this regression was introduced in 7877cfa

[mgreter]

I get the expected result?

p {
  content: "ABCD";
  content: "ABCD";
  content: "ABCDefg";
  content: "ABCD"; }

# psass -v
psass 0.4.0 (perl sass/scss compiler)
  libsass: 3.2.0-beta.6-4-g8963
  sass2scss: 1.0.3

Btw. I'm testing this on windows 7.

[xzyfer]

I get the reported result on master on OSX

p {
  content: '"ABCD"';
  content: '"ABCD"';
  content: '"ABCD"efg';
  content: "ABCD"; }

➜  libsass git:(master) ✗ sassc -v
sassc: 3.2.0-beta.2
libsass: 3.2.0-beta.6-4-g8963
sass2scss: 1.0.3

[xzyfer]

I've got a working fix for this. Required a decent amount of refactoring. I'll PR something tomorrow after I've cleaned it up.

[sndrs]

thank you! 😍