Make faster experimental #1
Conversation
| -spec value(orswot()) -> [member()]. | ||
| -spec value(orswot() | legacy_orswot()) -> [member()]. | ||
| value({_Clock, Entries, _Deferred}) when is_list(Entries) -> | ||
| [K || {K, _Dots} <- orddict:to_list(Entries)]; |
There was a problem hiding this comment.
Yeah, but in this case you are already checking is_list(Entries) then why orddict:to_list?
There was a problem hiding this comment.
Because, orddict is an opaque type (even though we know it's implemented as a list).
| Deffered = merge_deferred(LHSDeferred, RHSDeferred), | ||
| apply_deferred(Clock, Entries, Deffered); | ||
| merge(?EMPTY_ORSWOT, RHS) -> RHS; | ||
| merge(LHS, ?EMPTY_ORSWOT) -> LHS; |
There was a problem hiding this comment.
Should we move EMPTY_ORSWOT pattern match above Deferred checks?
There was a problem hiding this comment.
We should try to merge deferred if we can.
There was a problem hiding this comment.
You want to do that only if it is non-empty. For Empty ones there is no merge, right?
|
|
||
| -spec remove_elem({ok, riak_dt_vclock:vclock()} | error, | ||
| member(), {riak_dt_vclock:vclock(), orddict:orddict(), deferred()}) -> | ||
| member(), orswot()) -> | ||
| {ok, {riak_dt_vclock:vclock(), orddict:orddict(), deferred()}} | |
There was a problem hiding this comment.
orddict --> map in return typespec?
There was a problem hiding this comment.
return typespec {ok, {riak_dt_vclock:vclock(), orddict:orddict(), deferred()}} -> {ok, {riak_dt_vclock:vclock(), map(), deferred()}}.
| equal({Clock1, Entries1, _}, {Clock2, Entries2, _}) -> | ||
| riak_dt_vclock:equal(Clock1, Clock2) andalso | ||
| orddict:fetch_keys(Entries1) == orddict:fetch_keys(Entries2) andalso | ||
| Entries1 == Entries2 andalso |
There was a problem hiding this comment.
maybe move Entries1 == Entries2 check as the first one?
There was a problem hiding this comment.
Comparing the vclocks is faster because that's implemented in C :).
|
Pushed your changes. |
|
lgtm |
No description provided.