Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions when pasting nodes #147

Open
blowfishpro opened this issue May 13, 2019 · 1 comment
Open

Exceptions when pasting nodes #147

blowfishpro opened this issue May 13, 2019 · 1 comment
Assignees

Comments

@blowfishpro
Copy link
Collaborator

[LOG 2019-05-12 21:38:47.614] Applying update KerbalAtomicsLH2NTRModSupport/hydrogenNTRsMissingHistory/@PART[nuclearEngine_size0]:NEEDS[MissingHistory]:BEFORE[zzLH2NTR] to MissingHistory/PorkjetParts/AtomicAge/KANDL/KANDL.cfg/PART
[EXC 2019-05-12 21:38:47.614] System.NullReferenceException: Object reference not set to an instance of an object
  at ModuleManager.MMPatchLoader.FindConfigNodeIn (.ConfigNode src, System.String nodeType, System.String nodeName, Int32 index) [0x00000] in <filename unknown>:0 
  at ModuleManager.MMPatchLoader.RecurseNodeSearch (System.String path, ModuleManager.Collections.ImmutableStack`1 nodeStack, PatchContext context) [0x00000] in <filename unknown>:0 
  at ModuleManager.MMPatchLoader.RecurseNodeSearch (System.String path, ModuleManager.Collections.ImmutableStack`1 nodeStack, PatchContext context) [0x00000] in <filename unknown>:0 
  at ModuleManager.MMPatchLoader.RecurseNodeSearch (System.String path, ModuleManager.Collections.ImmutableStack`1 nodeStack, PatchContext context) [0x00000] in <filename unknown>:0 
  at ModuleManager.MMPatchLoader.ModifyNode (ModuleManager.Collections.ImmutableStack`1 original, .ConfigNode mod, PatchContext context) [0x00000] in <filename unknown>:0 
  at ModuleManager.MMPatchLoader.ModifyNode (ModuleManager.Collections.ImmutableStack`1 original, .ConfigNode mod, PatchContext context) [0x00000] in <filename unknown>:0 
  at ModuleManager.MMPatchLoader.ModifyNode (ModuleManager.Collections.ImmutableStack`1 original, .ConfigNode mod, PatchContext context) [0x00000] in <filename unknown>:0 
  at ModuleManager.Patches.EditPatch.Apply (System.Collections.Generic.LinkedList`1 databaseConfigs, IPatchProgress progress, IBasicLogger logger) [0x00000] in <filename unknown>:0 
[LOG 2019-05-12 21:38:47.614] Applying update KerbalAtomicsLH2NTRModSupport/hydrogenNTRsMissingHistory/@PART[nuclearEngine_1p5]:NEEDS[MissingHistory]:BEFORE[zzLH2NTR] to MissingHistory/PorkjetParts/AtomicAge/BKN/BKN.cfg/PART
[EXC 2019-05-12 21:38:47.614] System.NullReferenceException: Object reference not set to an instance of an object
  at ModuleManager.MMPatchLoader.FindConfigNodeIn (.ConfigNode src, System.String nodeType, System.String nodeName, Int32 index) [0x00000] in <filename unknown>:0 
  at ModuleManager.MMPatchLoader.RecurseNodeSearch (System.String path, ModuleManager.Collections.ImmutableStack`1 nodeStack, PatchContext context) [0x00000] in <filename unknown>:0 
  at ModuleManager.MMPatchLoader.RecurseNodeSearch (System.String path, ModuleManager.Collections.ImmutableStack`1 nodeStack, PatchContext context) [0x00000] in <filename unknown>:0 
  at ModuleManager.MMPatchLoader.RecurseNodeSearch (System.String path, ModuleManager.Collections.ImmutableStack`1 nodeStack, PatchContext context) [0x00000] in <filename unknown>:0 
  at ModuleManager.MMPatchLoader.ModifyNode (ModuleManager.Collections.ImmutableStack`1 original, .ConfigNode mod, PatchContext context) [0x00000] in <filename unknown>:0 
  at ModuleManager.MMPatchLoader.ModifyNode (ModuleManager.Collections.ImmutableStack`1 original, .ConfigNode mod, PatchContext context) [0x00000] in <filename unknown>:0 
  at ModuleManager.MMPatchLoader.ModifyNode (ModuleManager.Collections.ImmutableStack`1 original, .ConfigNode mod, PatchContext context) [0x00000] in <filename unknown>:0 
  at ModuleManager.Patches.EditPatch.Apply (System.Collections.Generic.LinkedList`1 databaseConfigs, IPatchProgress progress, IBasicLogger logger) [0x00000] in <filename unknown>:0 
[LOG 2019-05-12 21:38:47.614] Applying update KerbalAtomicsLH2NTRModSupport/hydrogenNTRsMissingHistory/@PART[nuclearEngine_1p5]:NEEDS[NearFutureElectrical&MissingHistory]:BEFORE[zzLH2NTR] to MissingHistory/PorkjetParts/AtomicAge/BKN/BKN.cfg/PART

from https://github.com/ChrisAdderley/KerbalAtomics/blob/84f94a4c475e3b46699e49b595152dd3a8c7b033/Extras/KerbalAtomicsLH2NTRModSupport/hydrogenNTRsMissingHistory.cfg

@blowfishpro blowfishpro self-assigned this May 13, 2019
@Wyzard256
Copy link

Details are in post-kerbin-mining-corporation/KerbalAtomics#74. Bottom line is that it's trying to copy from a node that doesn't exist (because another patch deleted it beforehand). On the KerbalAtomics side, the fix is to use the correct node path in the patch, but from an MM standpoint it seems like a bug that this throws an exception instead of just being reported as an erroneous patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants