Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Banshee] Filter is applied after gamma #2

Open
leilei- opened this issue May 17, 2021 · 0 comments
Open

[Banshee] Filter is applied after gamma #2

leilei- opened this issue May 17, 2021 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@leilei-
Copy link
Contributor

leilei- commented May 17, 2021

Describe the bug
The video filter is applied after the gamma correction process, rendering the filter ineffective.

To Reproduce

  • Set gamma to 1.0, see the filter work.
  • Set gamma to anything higher, see the filter not work.

Expected behavior
The gamma correction applying to the filtered buffer.

Additional context
When I've first reverse-engineered the filter in 2013, I did it on a 3dfx Voodoo3 3000 and relied on gamma behavior to observe the filter results with dark lines on black backgrounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants