Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

fix(Input): Padding, Icon color, & Floating changes #78

Merged
merged 11 commits into from
Sep 16, 2019

Conversation

mathewmorris
Copy link
Contributor

@mathewmorris mathewmorris commented Sep 13, 2019

  • Proper padding
  • Default Icon color
  • Default right Icon size
  • Floating animation/styles
  • New isFloating rule
  • Textarea floating
  • Form Error margin
  • Form Error in story

@ci-reporter

This comment has been minimized.

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #78 into v5 will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v5      #78      +/-   ##
==========================================
+ Coverage   66.66%   66.74%   +0.07%     
==========================================
  Files          20       20              
  Lines         450      451       +1     
  Branches       91       91              
==========================================
+ Hits          300      301       +1     
  Misses        120      120              
  Partials       30       30
Impacted Files Coverage Δ
src/Form/Input.js 56.33% <100%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f587776...0dc94e5. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #78 into v5 will decrease coverage by 0.5%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v5      #78      +/-   ##
==========================================
- Coverage   66.66%   66.15%   -0.51%     
==========================================
  Files          20       20              
  Lines         450      458       +8     
  Branches       91       92       +1     
==========================================
+ Hits          300      303       +3     
- Misses        120      124       +4     
- Partials       30       31       +1
Impacted Files Coverage Δ
src/theme.js 100% <ø> (ø) ⬆️
src/Form/Label.js 50% <ø> (ø) ⬆️
src/Form/FormError.js 22.22% <ø> (ø) ⬆️
src/Form/Input.js 53.84% <50%> (-1.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f587776...50ed0e4. Read the comment docs.

@mathewmorris mathewmorris changed the title fix(Input): Padding & Icon color fix(Input): Padding, Icon color, & Floating changes Sep 16, 2019
@mathewmorris mathewmorris marked this pull request as ready for review September 16, 2019 16:20
@mathewmorris mathewmorris merged commit 96bebb9 into v5 Sep 16, 2019
@mathewmorris mathewmorris deleted the fix/input-padding-icon-color branch September 16, 2019 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants