feat(Colors): Update Taylor Primary to Taylor Dark #76

kylealwyn · 2019-09-12T18:06:02Z

Old Taylor primary was feeling too pastel-y across the various mediums we were testing the palettes on.

ci-reporter · 2019-09-12T18:08:14Z

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Travis CI build is failing as of 9e2078c. Here's the output:

`npm test`

-- --coverage

> [email protected] test /home/travis/build/heydoctor/molekule
> jest "--coverage"

PASS src/Dropdown/Dropdown.spec.js
FAIL src/Form/DateInput.spec.js
  ● <DateInput /> › snapshot

    expect(received).toMatchSnapshot()

    Snapshot name: `<DateInput /> snapshot 1`

    - Snapshot
    + Received

    @@ -34,11 +34,11 @@
      .c3:active {
        border-color: #A4A6AA;
      }
      
      .c3:focus {
    -   border-color: #226EFF;
    +   border-color: #0958F3;
      }
      
      .c3::-webkit-input-placeholder {
        color: #767980;
      }

      26 |   test('snapshot', () => {
      27 |     const { asFragment } = renderInput();
    > 28 |     expect(asFragment()).toMatchSnapshot();
         |                          ^
      29 |   });
      30 | 
      31 |   test('initally sets the value', () => {

      at Object.toMatchSnapshot (src/Form/DateInput.spec.js:28:26)

 › 1 snapshot failed.
FAIL src/Form/PhoneInput.spec.js
  ● <PhoneInput /> › snapshot

    expect(received).toMatchSnapshot()

    Snapshot name: `<PhoneInput /> snapshot 1`

    - Snapshot
    + Received

    @@ -34,11 +34,11 @@
      .c3:active {
        border-color: #A4A6AA;
      }
      
      .c3:focus {
    -   border-color: #226EFF;
    +   border-color: #0958F3;
      }
      
      .c3::-webkit-input-placeholder {
        color: #767980;
      }

      21 |   test('snapshot', () => {
      22 |     const { asFragment } = renderInput();
    > 23 |     expect(asFragment()).toMatchSnapshot();
         |                          ^
      24 |   });
      25 | 
      26 |   test('initally sets the value', () => {

      at Object.toMatchSnapshot (src/Form/PhoneInput.spec.js:23:26)

 › 1 snapshot failed.
PASS src/utils.spec.js
PASS src/Linkify/Linkify.spec.js
FAIL src/Tabs/Tabs.spec.js
  ● <Tabs /> › renders

    expect(received).toMatchSnapshot()

    Snapshot name: `<Tabs /> renders 1`

    - Snapshot
    + Received

    @@ -62,16 +62,16 @@
      
      .c4 {
        display: block;
        color: #494D55;
        padding: 12px 8px;
    -   border-bottom: 4px solid #226EFF;
    +   border-bottom: 4px solid #0958F3;
      }
      
      .c4::hover {
        color: #212b36;
    -   border-color: #226EFF;
    +   border-color: #0958F3;
      }
      
      .c5 {
        display: block;
        color: #A4A6AA;

      27 |     const { asFragment } = renderWithTheme(<Tabs tabs={TABS} />);
      28 | 
    > 29 |     expect(asFragment()).toMatchSnapshot();
         |                          ^
      30 |   });
      31 | });
      32 | 

      at Object.toMatchSnapshot (src/Tabs/Tabs.spec.js:29:26)

 › 1 snapshot failed.
PASS src/Icon/Icon.spec.js
PASS src/Card/Card.spec.js
PASS src/Badge/Badge.spec.js
-------------------|----------|----------|----------|----------|-------------------|
File               |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
-------------------|----------|----------|----------|----------|-------------------|
All files          |    67.23 |    52.09 |    60.24 |    66.67 |                   |
 src               |       95 |    88.89 |    94.74 |    96.23 |                   |
  theme.js         |      100 |      100 |      100 |      100 |                   |
  utils.js         |    93.88 |    88.57 |    94.44 |    95.24 |             79,80 |
 src/Badge         |      100 |      100 |      100 |      100 |                   |
  Badge.js         |      100 |      100 |      100 |      100 |                   |
 src/Box           |      100 |      100 |      100 |      100 |                   |
  Box.js           |      100 |      100 |      100 |      100 |                   |
  index.js         |        0 |        0 |        0 |        0 |                   |
 src/Card          |      100 |       50 |      100 |      100 |                   |
  Card.js          |      100 |       50 |      100 |      100 |                12 |
 src/Dropdown      |    94.12 |    66.67 |    95.45 |    93.65 |                   |
  Dropdown.js      |    94.12 |    66.67 |    95.45 |    93.65 |   338,339,341,342 |
 src/Form          |    46.95 |     37.5 |     33.7 |    47.04 |                   |
  DateInput.js     |    90.48 |       84 |      100 |       90 |       62,63,67,81 |
  EasyInput.js     |    72.73 |    18.18 |      100 |    66.67 |          18,20,24 |
  Field.js         |      100 |      100 |      100 |      100 |                   |
  FormError.js     |       20 |        0 |        0 |    22.22 |... 21,22,23,25,27 |
  Formbot.js       |      4.6 |        0 |        0 |     4.82 |... 24,233,246,248 |
  Input.js         |    55.71 |     47.3 |    52.63 |    55.71 |... 70,273,277,281 |
  Label.js         |       50 |        0 |        0 |       50 |                 7 |
  PhoneInput.js    |    76.92 |       70 |      100 |    76.92 |... 45,46,47,52,66 |
 src/Icon          |      100 |       70 |      100 |      100 |                   |
  Icon.js          |      100 |       70 |      100 |      100 |          17,19,25 |
  index.js         |        0 |        0 |        0 |        0 |                   |
 src/Linkify       |    91.67 |       50 |      100 |    90.91 |                   |
  Linkify.js       |    91.67 |       50 |      100 |    90.91 |                29 |
 src/Portal        |        0 |        0 |        0 |        0 |                   |
  index.js         |        0 |        0 |        0 |        0 |                   |
 src/Tabs          |    70.97 |    52.63 |       75 |    70.97 |                   |
  Tabs.js          |    70.97 |    52.63 |       75 |    70.97 |... 36,137,139,155 |
 src/ThemeProvider |      100 |      100 |      100 |      100 |                   |
  ThemeProvider.js |      100 |      100 |      100 |      100 |                   |
  index.js         |        0 |        0 |        0 |        0 |                   |
 src/hooks         |      100 |      100 |      100 |      100 |                   |
  index.js         |        0 |        0 |        0 |        0 |                   |
  useKeyPress.js   |      100 |      100 |      100 |      100 |                   |
 test              |      100 |      100 |      100 |      100 |                   |
  utils.js         |      100 |      100 |      100 |      100 |                   |
-------------------|----------|----------|----------|----------|-------------------|

Snapshot Summary
 › 3 snapshots failed from 3 test suites. Inspect your code changes or run `npm test -- -u` to update them.

Test Suites: 3 failed, 6 passed, 9 total
Tests:       3 failed, 39 passed, 42 total
Snapshots:   3 failed, 17 passed, 20 total
Time:        9.211s
Ran all test suites.

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

codecov · 2019-09-12T18:16:25Z

Codecov Report

Merging #76 into v5 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##               v5      #76   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files          20       20           
  Lines         450      450           
  Branches       91       91           
=======================================
  Hits          300      300           
  Misses        120      120           
  Partials       30       30

Impacted Files	Coverage Δ
src/theme.js	`100% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a38c5...472a900. Read the comment docs.

codecov · 2019-09-12T18:16:25Z

Codecov Report

Merging #76 into v5 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##               v5      #76   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files          20       20           
  Lines         450      450           
  Branches       91       91           
=======================================
  Hits          300      300           
  Misses        120      120           
  Partials       30       30

Impacted Files	Coverage Δ
src/theme.js	`100% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a38c5...472a900. Read the comment docs.

erikshestopal · 2019-09-12T18:18:12Z

@kylealwyn do we want to do the same in the mobile-app?

kylealwyn · 2019-09-12T18:18:42Z

@erikshestopal Yes please. Palette is updated in Figma but can also use hex codes here

Dark taylor becomes taylor primary

9e2078c

kylealwyn changed the title ~~Dark taylor becomes taylor primary~~ feat(Colors): Dark taylor becomes taylor primary Sep 12, 2019

kylealwyn changed the title ~~feat(Colors): Dark taylor becomes taylor primary~~ feat(Colors): Update Taylor Primary to Taylor Dark Sep 12, 2019

Snaps

472a900

kylealwyn requested a review from erikshestopal September 12, 2019 18:17

erikshestopal approved these changes Sep 12, 2019

View reviewed changes

mathewmorris approved these changes Sep 12, 2019

View reviewed changes

kylealwyn merged commit b4c589a into v5 Sep 12, 2019

kylealwyn deleted the update-blues branch September 12, 2019 19:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Colors): Update Taylor Primary to Taylor Dark #76

feat(Colors): Update Taylor Primary to Taylor Dark #76

kylealwyn commented Sep 12, 2019

ci-reporter bot commented Sep 12, 2019

codecov bot commented Sep 12, 2019

codecov bot commented Sep 12, 2019 •

edited

Loading

erikshestopal commented Sep 12, 2019

kylealwyn commented Sep 12, 2019

feat(Colors): Update Taylor Primary to Taylor Dark #76

feat(Colors): Update Taylor Primary to Taylor Dark #76

Conversation

kylealwyn commented Sep 12, 2019

ci-reporter bot commented Sep 12, 2019

The build is failing

npm test

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

codecov bot commented Sep 12, 2019

Codecov Report

codecov bot commented Sep 12, 2019 • edited Loading

Codecov Report

erikshestopal commented Sep 12, 2019

kylealwyn commented Sep 12, 2019

`npm test`

codecov bot commented Sep 12, 2019 •

edited

Loading