This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
feat: Add floating label to select #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## v5 #73 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 20 20
Lines 450 450
Branches 91 91
=======================================
Hits 300 300
Misses 120 120
Partials 30 30Continue to review full report at Codecov.
|
|
Could we have this go into v5, which will be landing soon, so we don’t have to worry about any conflicts? |
cehsu
force-pushed
the
feat/floatable-select
branch
from
96537ab to
662cd87
Compare
kylealwyn
approved these changes
Sep 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes bring the select component up to date with other form elements that support floating labels.
Task: https://app.asana.com/0/1127722639002160/1135318045362828/f