Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

fix(FormBot): Remove validation chaining for async validations #65

Merged
merged 3 commits into from
Aug 21, 2019

Conversation

schlegz
Copy link
Contributor

@schlegz schlegz commented Aug 21, 2019

Fixes an issue in some browsers that do not support chaining finally.

Asana: https://app.asana.com/0/1127722639002160/1136619333118829/f

@schlegz schlegz added the bug Something isn't working label Aug 21, 2019
@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #65 into master will increase coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   66.29%   66.44%   +0.14%     
==========================================
  Files          22       22              
  Lines         451      450       -1     
  Branches       91       91              
==========================================
  Hits          299      299              
+ Misses        123      122       -1     
  Partials       29       29
Impacted Files Coverage Δ
src/Form/Formbot.js 2.77% <0%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 926c60a...347c3cd. Read the comment docs.

@schlegz schlegz marked this pull request as ready for review August 21, 2019 19:21
@schlegz schlegz requested a review from a team August 21, 2019 19:21
@ghost ghost requested review from cehsu and choochootrain August 21, 2019 19:21
@schlegz schlegz requested review from kylealwyn and removed request for choochootrain and cehsu August 21, 2019 19:21
@cehsu cehsu self-requested a review August 21, 2019 19:30
Copy link
Contributor

@cehsu cehsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but doesn't seem to behave as expected when QAing, will keep looking.

@schlegz schlegz merged commit fff8c25 into master Aug 21, 2019
@schlegz schlegz deleted the fix/validation-chain-finally branch August 21, 2019 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants