This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
feat(Colors): Updates colors #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## v5 #60 +/- ##
=======================================
Coverage 66.29% 66.29%
=======================================
Files 22 22
Lines 451 451
Branches 91 91
=======================================
Hits 299 299
Misses 123 123
Partials 29 29
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## v5 #60 +/- ##
=======================================
Coverage 66.29% 66.29%
=======================================
Files 22 22
Lines 451 451
Branches 91 91
=======================================
Hits 299 299
Misses 123 123
Partials 29 29
Continue to review full report at Codecov.
|
erikshestopal
approved these changes
Aug 16, 2019
mathewmorris
added a commit
that referenced
this pull request
Aug 23, 2019
* v5: feat(Button): Icon support and default style updates (#51) feat(Colors): Updates colors (#60) chore(release): 4.1.6 fix(FormError): Fix crash in case context is null (#59) chore(release): 4.1.5 fix: Use updater function in setState for Formbot updates (#58) chore(release): 4.1.4 fix(validations): Fix handling of async validations as well as order of onChange notification (#57) chore(release): 4.1.3 Async Formbot Validations (#56)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of existing PRs that rely on the colors being updated. Instead of making those changes on every PR, I made this to update colors in one sweep.
Colors were changed for specific components because
gray => greyas well as basic theme file changes. If any components match the Figma file (as far as colors go), it is purely coincidence. Those specific changes will be made in their respective PRs.Colors like
greenandbluewere kept to mitigate breaking changes. Coincidentally, our primary and secondary colors are blue/green so it's only natural to make those the blue and green for our color scheme. But I wanted to leave those colors in to make this work out of the box.