Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

fix(Dropdown): Fix SSR by removing direct reference to Element in prop types #43

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

kylealwyn
Copy link
Contributor

@kylealwyn kylealwyn commented Jun 21, 2019

Gatsby breaks when building:

11:24:58 AM:   2842 |   transitionDuration: PropTypes.number,
11:24:58 AM:   2843 |   transitionTimingFunction: PropTypes.string,
11:24:58 AM: > 2844 |   portalNode: PropTypes.instanceOf(Element)
11:24:58 AM:        |                        ^
11:24:58 AM:   2845 | };
11:24:58 AM:   2846 | Dropdown.defaultProps = {
11:24:58 AM:   2847 |   placement: 'bottom-start',
11:24:58 AM: 
11:24:58 AM:   WebpackError: ReferenceError: Element is not defined

@kylealwyn kylealwyn requested a review from a team June 21, 2019 18:30
@ghost ghost requested review from choochootrain and erikshestopal June 21, 2019 18:30
@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   68.36%   68.36%           
=======================================
  Files          22       22           
  Lines         433      433           
  Branches       92       92           
=======================================
  Hits          296      296           
  Misses        107      107           
  Partials       30       30
Impacted Files Coverage Δ
src/Dropdown/Dropdown.js 92.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b3c0b...c5ba8e8. Read the comment docs.

@kylealwyn kylealwyn changed the title fix(Dropdown): Remove direct reference to Element which breaks SSR fix(Dropdown): Fix SSR by removing direct reference to Element in prop types Jun 21, 2019
@kylealwyn kylealwyn merged commit ce080cf into master Jun 21, 2019
@kylealwyn kylealwyn deleted the fix/dropdown-prop-types branch June 21, 2019 18:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants