Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

fix(PhoneInput): Cast null to empty string #40

Merged
merged 1 commit into from
Apr 24, 2019
Merged

fix(PhoneInput): Cast null to empty string #40

merged 1 commit into from
Apr 24, 2019

Conversation

kylealwyn
Copy link
Contributor

Not sure where/how the value is being set to null, so adding this defensive cast until we can dig more

https://sentry.io/organizations/heydoctor/issues/996939211/?environment=beta&project=290802&query=is%3Aunresolved

@kylealwyn kylealwyn requested a review from a team April 24, 2019 17:14
@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #40 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   68.28%   68.36%   +0.07%     
==========================================
  Files          22       22              
  Lines         432      433       +1     
  Branches       91       91              
==========================================
+ Hits          295      296       +1     
  Misses        107      107              
  Partials       30       30
Impacted Files Coverage Δ
src/Form/PhoneInput.js 74.35% <100%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b18d5a...265b4e8. Read the comment docs.

Copy link

@choochootrain choochootrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@kylealwyn kylealwyn merged commit c311c6c into master Apr 24, 2019
@kylealwyn kylealwyn deleted the null-phone branch April 24, 2019 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants