Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

fix(Dropdown): Configure <Dropdown.Trigger/> style #33

Merged
merged 4 commits into from
Mar 22, 2019

Conversation

cehsu
Copy link
Contributor

@cehsu cehsu commented Mar 22, 2019

These changes allow the <Dropdown/> component's <TriggerWrapper/>(styled(Dropdown.Trigger)) to be styled so that it may, for example, fill the available width of its parent container.
image

@cehsu cehsu requested a review from a team March 22, 2019 19:23
@codecov-io
Copy link

codecov-io commented Mar 22, 2019

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files          13       13           
  Lines         198      198           
  Branches       31       31           
=======================================
  Hits          176      176           
  Misses         15       15           
  Partials        7        7
Impacted Files Coverage Δ
src/Dropdown/Dropdown.js 92.85% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f518a08...9c9d9ed. Read the comment docs.

src/Dropdown/Dropdown.js Outdated Show resolved Hide resolved
Copy link

@choochootrain choochootrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@kylealwyn kylealwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@cehsu cehsu merged commit dd948a6 into master Mar 22, 2019
@cehsu cehsu deleted the fix/dropdown-trigger-style branch March 22, 2019 22:13
@cehsu cehsu changed the title (fix)Dropdown: Configure <Dropdown.Trigger/> style fix(Dropdown): Configure <Dropdown.Trigger/> style Mar 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants