Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

fix: Forward input refs, add missing form export, remove autogrow shadow element from tab order #22

Merged
merged 3 commits into from
Feb 26, 2019

Conversation

choochootrain
Copy link

No description provided.

@choochootrain choochootrain requested a review from a team February 26, 2019 20:09
@erikshestopal
Copy link
Contributor

Would it be too much to ask for you to add a tabIndex={-1} to the shadow input here?
This shadow input messes up tabbing to the next input if the first Input component has autogrow as a prop.

If you plop this code into the molekule docs playground, you'll see that it takes two tab presses to get to the next input element.

<Input
  multiline
  autogrow
  placeholder="Example"
  label="Example"
  value="I already have a value! If provided a value, I become controlled, so I won't update when you type here..."
/>

<Input placeholder="Example" label="Example"  />

@codecov-io
Copy link

codecov-io commented Feb 26, 2019

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   71.91%   71.91%           
=======================================
  Files          12       12           
  Lines         146      146           
  Branches       19       19           
=======================================
  Hits          105      105           
  Misses         31       31           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc2a90...9c42c8f. Read the comment docs.

@choochootrain choochootrain changed the title Add missing form export fix: Forward input refs, add missing form export, remove autogrow shadow element from tab order Feb 26, 2019
@choochootrain choochootrain merged commit 424195d into master Feb 26, 2019
@choochootrain choochootrain deleted the fix/export-form branch February 26, 2019 23:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants